Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Log Revision Writes from Map Writes #1263

Merged
merged 11 commits into from Apr 23, 2019

Conversation

Projects
None yet
4 participants
@therealdrake
Copy link
Contributor

commented Apr 19, 2019

Moved PublishRevision out of RunBatch and created its own function to call periodically. Publishing to the log and writing to the map are independent actions.

therealdrake added some commits Apr 19, 2019

@therealdrake therealdrake requested a review from google/keytransparency as a code owner Apr 19, 2019

@googlebot googlebot added the cla: yes label Apr 19, 2019

Show resolved Hide resolved cmd/keytransparency-sequencer/main.go Outdated
Show resolved Hide resolved core/sequencer/sequencer.go

therealdrake added some commits Apr 19, 2019

@therealdrake therealdrake requested review from jtoohill and gdbelvin Apr 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 19, 2019

Codecov Report

Merging #1263 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage    32.4%   32.31%   -0.09%     
==========================================
  Files          45       45              
  Lines        3537     3546       +9     
==========================================
  Hits         1146     1146              
- Misses       2207     2216       +9     
  Partials      184      184
Impacted Files Coverage Δ
core/sequencer/sequencer.go 0% <0%> (ø) ⬆️
core/sequencer/server.go 46.85% <0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f59d79...3c83375. Read the comment docs.

Show resolved Hide resolved cmd/keytransparency-sequencer/main.go
Show resolved Hide resolved cmd/keytransparency-sequencer/main.go Outdated

therealdrake added some commits Apr 23, 2019

@therealdrake therealdrake merged commit ab5619b into master Apr 23, 2019

4 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.