Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to travis-ci.com #1289

Merged
merged 2 commits into from May 31, 2019

Conversation

Projects
None yet
4 participants
@gdbelvin
Copy link
Collaborator

commented May 29, 2019

Use the travis-ci GitHub Apps integration, remove the old services based integration

https://blog.travis-ci.com/2018-05-02-open-source-projects-on-travis-ci-com-with-github-apps

TravisCI.com uses a smaller permission set:

@gdbelvin gdbelvin requested a review from RJPercival May 29, 2019

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner May 29, 2019

@googlebot googlebot added the cla: yes label May 29, 2019

@codecov

This comment has been minimized.

Copy link

commented May 29, 2019

Codecov Report

Merging #1289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1289   +/-   ##
=======================================
  Coverage   31.95%   31.95%           
=======================================
  Files          45       45           
  Lines        3655     3655           
=======================================
  Hits         1168     1168           
  Misses       2307     2307           
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8b1b4...089cb2f. Read the comment docs.

@Martin2112

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

As discussed offline not sure we can move yet.

@RJPercival
Copy link
Member

left a comment

Does the old webhook still need to be deleted in order to remove the stalled "continuous-integration/travis-ci" check that is showing up below PRs? Also, have you confirmed that the documented permission set is the actual permission set that it's requesting? If I try to login on https://travis-ci.com, it asks for write access to repos.

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

Yes, I needed to change the required check to TravisCI.

I've confirmed the permissions in all the ways I know how. Could you attach a screenshot of what you're seeing?

@Martin2112

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Yes I don't think you can sign into travis-ci.com without giving it repo write access. Please double check that and if so you need to revoke it.

@RJPercival

This comment has been minimized.

Copy link
Member

commented May 30, 2019

If that's a screenshot of the permissions that the GitHub App is requesting, then this seems fine. It appears that logging into travis-ci.com requires a larger set of permissions for some reason but, so long as you don't need to do that, it should be fine.

@RJPercival RJPercival assigned gdbelvin and unassigned RJPercival May 30, 2019

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2019

It does indeed look like the OAuth permissions to view travis-ci.com are sepate

are a separate thing from the GitHub App

Here's the screenshot from logging in, and the expanded set of permissions is the "Full control of private repos" line.

Screenshot 2019-05-30 at 14 20 50

According to both of the following links, GitHub OAuth apps do not support read-only access for source code access. This is likely the source of the issue.

Note that OAuth permissions only apply to individual user accounts, not organizational repos.

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2019

The GitHub App integration is what allows the pull requests to be processed and tested. This has already been installed by the org admin.

The OAuth permission is what allows individual users to login to travis-ci.com

@gdbelvin gdbelvin removed their assignment May 30, 2019

@gdbelvin gdbelvin merged commit 185dc4b into google:master May 31, 2019

5 checks passed

GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 1d8b1b4...089cb2f
Details
codecov/project 31.95% remains the same compared to 1d8b1b4
Details

@gdbelvin gdbelvin deleted the gdbelvin:build_badge branch May 31, 2019

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jun 3, 2019

Merge branch 'master' into NoProof
* master:
  Move to travis-ci.com (google#1289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.