Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetMapLeavesNoProof #1292

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@gdbelvin
Copy link
Collaborator

commented May 31, 2019

It's not necessary to fully verify the results from the Trillian Map inside the sequencer because
this effort is duplicated by clients.

Depends on google/trillian#1647

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner May 31, 2019

@googlebot googlebot added the cla: yes label May 31, 2019

@gdbelvin gdbelvin requested a review from pavelkalinnikov May 31, 2019

Show resolved Hide resolved core/sequencer/trillian_client.go
Show resolved Hide resolved core/sequencer/server_test.go Outdated
@codecov

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #1292 into master will decrease coverage by 0.68%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
- Coverage   31.95%   31.26%   -0.69%     
==========================================
  Files          45       45              
  Lines        3655     3665      +10     
==========================================
- Hits         1168     1146      -22     
- Misses       2307     2343      +36     
+ Partials      180      176       -4
Impacted Files Coverage Δ
core/sequencer/server.go 39.57% <0%> (-7.78%) ⬇️
core/sequencer/trillian_client.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062d977...1fe0f4f. Read the comment docs.

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 3, 2019

Show resolved Hide resolved core/sequencer/trillian_client.go
Show resolved Hide resolved core/sequencer/trillian_client.go Outdated
Show resolved Hide resolved core/sequencer/trillian_client.go Outdated
Show resolved Hide resolved core/sequencer/trillian_client.go Outdated
Show resolved Hide resolved go.mod Outdated

gdbelvin added some commits May 31, 2019

@gdbelvin gdbelvin force-pushed the gdbelvin:NoProof branch from 8bc6e28 to 0cf1803 Jun 3, 2019

@gdbelvin gdbelvin requested a review from pavelkalinnikov Jun 3, 2019

gdbelvin added some commits Jun 3, 2019

Remove duplicate test
Returning duplicates is not fatal, only a symptom of client logic bugs

@gdbelvin gdbelvin force-pushed the gdbelvin:NoProof branch from 0cf1803 to 1fe0f4f Jun 4, 2019

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 4, 2019

PTAL

@gdbelvin gdbelvin merged commit 2712830 into google:master Jun 4, 2019

3 of 5 checks passed

codecov/patch 0% of diff hit (target 31.95%)
Details
codecov/project 31.26% (-0.69%) compared to 062d977
Details
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed

@gdbelvin gdbelvin deleted the gdbelvin:NoProof branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.