Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'k' for keyset-file shorthand #1293

Merged
merged 2 commits into from Jun 6, 2019

Conversation

Projects
None yet
4 participants
@gdbelvin
Copy link
Collaborator

commented Jun 3, 2019

Viper has added a new restriction on the shorthand flags that
limit the shorthand to one character.

Fixes #1295

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Jun 3, 2019

@googlebot googlebot added the cla: yes label Jun 3, 2019

Use 'k' for keyset-file shorthand
Viper has added a new restriction on the shorthand flags that
limit the shorthand to one character.

@gdbelvin gdbelvin force-pushed the gdbelvin:flags branch from 5d1b111 to 09c3331 Jun 3, 2019

@gdbelvin gdbelvin requested a review from DazWilkin Jun 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #1293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1293   +/-   ##
=======================================
  Coverage   31.26%   31.26%           
=======================================
  Files          45       45           
  Lines        3665     3665           
=======================================
  Hits         1146     1146           
  Misses       2343     2343           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2712830...6b92a03. Read the comment docs.

@DazWilkin
Copy link
Collaborator

left a comment

LGTM

@mhutchinson
Copy link

left a comment

Looks good. This will resolve bug #1295

@gdbelvin gdbelvin merged commit a0ed60a into google:master Jun 6, 2019

5 checks passed

GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 2712830...6b92a03
Details
codecov/project 31.26% remains the same compared to 2712830
Details

@gdbelvin gdbelvin deleted the gdbelvin:flags branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.