Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test data files and struct fields to be more informative. #1296

Merged
merged 2 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@jtoohill
Copy link
Contributor

commented Jun 5, 2019

I'll follow up by adding more integration tests for batch verification.

Jon Toohill
Rename test data files and struct fields to be more informative.
I'll follow up by adding more integration tests for batch verification.

@jtoohill jtoohill requested review from gdbelvin and libinjG Jun 5, 2019

@jtoohill jtoohill requested review from thaidn and google/keytransparency as code owners Jun 5, 2019

@googlebot googlebot added the cla: yes label Jun 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #1296 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   31.26%   31.26%           
=======================================
  Files          45       45           
  Lines        3665     3665           
=======================================
  Hits         1146     1146           
  Misses       2343     2343           
  Partials      176      176
Impacted Files Coverage Δ
core/integration/client_tests.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ed60a...776126e. Read the comment docs.

@gdbelvin
Copy link
Collaborator

left a comment

Would you mind doing an import as well?

@jtoohill jtoohill merged commit 6e02f54 into google:master Jun 6, 2019

4 of 5 checks passed

codecov/patch 0% of diff hit (target 31.26%)
Details
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/project 31.26% remains the same compared to a0ed60a
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.