Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LogRootRequest in Request Protos #1329

merged 8 commits into from Aug 2, 2019


Copy link

commented Aug 1, 2019

This makes request, response pairs fully verifiable.

Responses can be verified in-line without needed to artificially inject LogRequestState into verifier.

This is best reviewed commit by commit.

Significant client changes:

  • Clients will now need to send the hash associated with their last verified log root.

gdbelvin added some commits Aug 1, 2019

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Aug 1, 2019

@googlebot googlebot added the cla: yes label Aug 1, 2019

@gdbelvin gdbelvin requested a review from jtoohill Aug 1, 2019

Copy link

left a comment

This is a really nice improvement to the API and code cleanliness!


This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

Merging #1329 into master will decrease coverage by 0.04%.
The diff coverage is 34.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
- Coverage   30.33%   30.28%   -0.05%     
  Files          48       48              
  Lines        3867     3866       -1     
- Hits         1173     1171       -2     
- Misses       2512     2513       +1     
  Partials      182      182
Impacted Files Coverage Δ
core/client/client.go 28.28% <ø> (-0.66%) ⬇️
core/keyserver/revisions.go 34.93% <0%> (ø) ⬆️
core/integration/client_tests.go 0% <0%> (ø) ⬆️
core/client/batch_get_and_verify.go 0% <0%> (ø) ⬆️
core/client/get_and_verify.go 23.45% <38.46%> (ø) ⬆️
core/client/verifier/pairs.go 21.05% <50%> (ø) ⬆️
core/keyserver/keyserver.go 40.78% <72.72%> (+0.14%) ⬆️
core/client/verifier/verifier.go 53.94% <0%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa29cd...a643949. Read the comment docs.

@gdbelvin gdbelvin merged commit 86e6578 into google:master Aug 2, 2019

6 checks passed

DEP All dependencies are resolved
GolangCI No issues found!
Travis CI - Pull Request Build Passed
cla/google All necessary CLAs are signed
codecov/patch 34.88% of diff hit (target 30.33%)
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +4.55% compared to 2aa29cd

@gdbelvin gdbelvin deleted the gdbelvin:request branch Aug 2, 2019

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Aug 5, 2019

Merge branch 'master' into vrf
* master:
  Include LogRootRequest in Request Protos (google#1329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.