Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment script. Use gcr.io consistently #1347

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@gdbelvin
Copy link
Collaborator

commented Aug 23, 2019

us.gcr.io -> gcr.io

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Aug 23, 2019

@googlebot googlebot added the cla: yes label Aug 23, 2019

@gdbelvin gdbelvin requested a review from pavelkalinnikov Aug 23, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #1347 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
- Coverage   30.52%   30.49%   -0.03%     
==========================================
  Files          48       48              
  Lines        3846     3846              
==========================================
- Hits         1174     1173       -1     
- Misses       2490     2491       +1     
  Partials      182      182
Impacted Files Coverage Δ
core/client/client.go 28.28% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f4fc3...bd60409. Read the comment docs.

@gdbelvin gdbelvin merged commit b7edc8f into google:master Aug 23, 2019

4 of 5 checks passed

codecov/project 30.49% (-0.03%) compared to 25f4fc3
Details
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 25f4fc3...bd60409
Details

@gdbelvin gdbelvin deleted the gdbelvin:rm_gcr branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.