Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RunBatch to ApplyRevisions #1351

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@pavelkalinnikov
Copy link
Contributor

commented Aug 30, 2019

This change removes the RunBatch API call, and introduces ApplyRevisions instead, with the same behavior.

@pavelkalinnikov pavelkalinnikov requested review from gdbelvin and jtoohill Aug 30, 2019

@pavelkalinnikov pavelkalinnikov requested a review from google/keytransparency as a code owner Aug 30, 2019

@googlebot googlebot added the cla: yes label Aug 30, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #1351 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
+ Coverage   30.53%   30.55%   +0.02%     
==========================================
  Files          48       48              
  Lines        3865     3865              
==========================================
+ Hits         1180     1181       +1     
+ Misses       2502     2501       -1     
  Partials      183      183
Impacted Files Coverage Δ
core/integration/client_tests.go 0% <0%> (ø) ⬆️
core/sequencer/sequencer.go 0% <0%> (ø) ⬆️
core/sequencer/server.go 40.89% <0%> (ø) ⬆️
core/client/client.go 28.94% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17e989...576ac7b. Read the comment docs.

@gdbelvin
Copy link
Collaborator

left a comment

Lgtm

@pavelkalinnikov pavelkalinnikov merged commit 0249a5c into google:master Aug 30, 2019

5 of 6 checks passed

codecov/patch 0% of diff hit (target 30.53%)
Details
DEP All dependencies are resolved
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/project 30.55% (+0.02%) compared to f17e989
Details

@pavelkalinnikov pavelkalinnikov deleted the pavelkalinnikov:rename_run_batch branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.