Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed go.mod file so the project builds with module-aware go v.1.13. #1352

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@mhutchinson
Copy link
Contributor

commented Sep 10, 2019

  • Upgraded Trillian version to latest:
  • Edited file to set version string for trillian to fa759d0
  • go get -u github.com/google/trillian@fa759d0
  • Added replace statement to map remaining broken upstream module dependency.

  • Ran go mod tidy

Fixed go.mod file so the project builds with module-aware go v.1.13.
* Upgraded Trillian version to latest.

* Added replace statement to map remaining broken upstream module dependency.

* Ran go mod tidy

@mhutchinson mhutchinson requested a review from gdbelvin Sep 10, 2019

@mhutchinson mhutchinson requested a review from google/keytransparency as a code owner Sep 10, 2019

@googlebot googlebot added the cla: yes label Sep 10, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 10, 2019

Codecov Report

Merging #1352 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   30.58%   30.57%   -0.01%     
==========================================
  Files          48       48              
  Lines        3868     3869       +1     
==========================================
  Hits         1183     1183              
- Misses       2502     2503       +1     
  Partials      183      183
Impacted Files Coverage Δ
impl/integration/env.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddb427...bbe1abf. Read the comment docs.

mhutchinson added 2 commits Sep 10, 2019
Disable funlen until we determine we want it.
This is a new check in the latest version of the golangci-lin. It sounds like a good idea, but we need to get this to build in travis before thinking about turning on new checks.

@mhutchinson mhutchinson merged commit 50f19ad into google:master Sep 10, 2019

2 of 5 checks passed

GolangCI can't run golangci-lint: internal error
Details
codecov/patch 0% of diff hit (target 30.58%)
Details
codecov/project 30.57% (-0.01%) compared to eddb427
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed

@mhutchinson mhutchinson deleted the mhutchinson:v1.13happy branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.