Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storagetest factory now takes domainID #1353

Merged
merged 4 commits into from Sep 11, 2019

Conversation

@gdbelvin
Copy link
Collaborator

commented Sep 11, 2019

Some storage implementations require a domain setup step
This switch allows the storage factory to do the nessesary
setup for the test.

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Sep 11, 2019

@googlebot googlebot added the cla: yes label Sep 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #1353 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1353     +/-   ##
=========================================
+ Coverage   65.28%   65.39%   +0.1%     
=========================================
  Files          48       48             
  Lines        3869     3869             
=========================================
+ Hits         2526     2530      +4     
+ Misses        958      956      -2     
+ Partials      385      383      -2
Impacted Files Coverage Δ
core/sequencer/server.go 70.3% <0%> (+0.68%) ⬆️
core/sequencer/trillian_client.go 51.8% <0%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6f4dc...01489a2. Read the comment docs.

gdbelvin added 3 commits Sep 11, 2019
nit

@gdbelvin gdbelvin merged commit 8df8fd2 into google:master Sep 11, 2019

4 of 5 checks passed

GolangCI can't run golangci-lint: internal error
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing c258273...01489a2
Details
codecov/project 65.39% (+0.1%) compared to c258273
Details

@gdbelvin gdbelvin deleted the gdbelvin:batch branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.