Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration tests in travis #1355

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@gdbelvin
Copy link
Collaborator

commented Sep 11, 2019

Turn on mysql in travis

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Sep 11, 2019

@googlebot googlebot added the cla: yes label Sep 11, 2019

@gdbelvin gdbelvin changed the title Enabled integration tests in travis Enable integration tests in travis Sep 11, 2019

gdbelvin added 2 commits Sep 11, 2019
@mhutchinson
Copy link
Contributor

left a comment

If Travis can build this, I approve.

@codecov

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #1355 into master will increase coverage by 34.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1355       +/-   ##
===========================================
+ Coverage   30.57%   65.28%   +34.71%     
===========================================
  Files          48       48               
  Lines        3869     3869               
===========================================
+ Hits         1183     2526     +1343     
+ Misses       2503      958     -1545     
- Partials      183      385      +202
Impacted Files Coverage Δ
core/client/verifier/verifier.go 56.57% <0%> (+2.63%) ⬆️
impl/sql/mutationstorage/queue.go 73.79% <0%> (+2.75%) ⬆️
core/mutator/entry/mutation.go 79.71% <0%> (+8.69%) ⬆️
impl/authentication/fake.go 100% <0%> (+11.11%) ⬆️
core/sequencer/sequencer.go 12% <0%> (+12%) ⬆️
core/crypto/commitments/commitments.go 88.88% <0%> (+16.66%) ⬆️
core/keyserver/validate.go 58.9% <0%> (+19.17%) ⬆️
core/keyserver/keyserver.go 61.86% <0%> (+20.2%) ⬆️
core/mutator/entry/mutator.go 60.46% <0%> (+20.93%) ⬆️
core/client/tracker/tracker.go 88.88% <0%> (+22.22%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b3833...c258273. Read the comment docs.

@gdbelvin gdbelvin merged commit 3a6f4dc into google:master Sep 11, 2019

4 of 5 checks passed

GolangCI can't run golangci-lint: internal error
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 06b3833...c258273
Details
codecov/project 65.28% (+34.71%) compared to 06b3833
Details

@gdbelvin gdbelvin deleted the gdbelvin:integration branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.