Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermetic set of linters #1365

Merged
merged 4 commits into from Oct 7, 2019

Conversation

@gdbelvin
Copy link
Collaborator

commented Oct 4, 2019

Create a hermetic set of tests in golangci with an explicit set of tests.

  • Enable whitelist linter
gdbelvin added 2 commits Oct 4, 2019
Don't automatically add new linters. Linters must be explicitly  added
@gdbelvin gdbelvin requested review from thaidn and google/keytransparency as code owners Oct 4, 2019
@googlebot googlebot added the cla: yes label Oct 4, 2019
@gdbelvin gdbelvin requested a review from mhutchinson Oct 4, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #1365 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage   65.39%   65.36%   -0.03%     
==========================================
  Files          48       48              
  Lines        3869     3869              
==========================================
- Hits         2530     2529       -1     
  Misses        956      956              
- Partials      383      384       +1
Impacted Files Coverage Δ
impl/authorization/interceptor.go 23.07% <ø> (ø) ⬆️
core/keyserver/revisions.go 62.32% <ø> (ø) ⬆️
core/sequencer/server.go 70.64% <ø> (+0.34%) ⬆️
impl/authorization/authorization.go 81.25% <ø> (ø) ⬆️
core/crypto/vrf/p256/unmarshal.go 82.85% <ø> (ø) ⬆️
core/sequencer/trillian_client.go 49.39% <0%> (-2.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470db41...a19ecd8. Read the comment docs.

@gdbelvin gdbelvin merged commit 7526357 into google:master Oct 7, 2019
3 checks passed
3 checks passed
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@gdbelvin gdbelvin deleted the gdbelvin:whitespace branch Oct 7, 2019
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Oct 7, 2019
* master:
  Hermetic set of linters (google#1365)
  Remove confusing -tags=mysql build flag (google#1363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.