Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #1387

Merged
merged 3 commits into from Nov 24, 2019
Merged

Upgrade dependencies #1387

merged 3 commits into from Nov 24, 2019

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Nov 21, 2019

go get github.com/google/trillian v1.3.3
go get -u ./...
go mod tidy

Closes #1386

```
go get github.com/google/trillian v1.3.3
go get -u ./...
go mod tidy
```
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Nov 21, 2019
@googlebot googlebot added the cla: yes label Nov 21, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #1387 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   65.92%   65.99%   +0.07%     
==========================================
  Files          52       52              
  Lines        3979     3979              
==========================================
+ Hits         2623     2626       +3     
+ Misses        959      957       -2     
+ Partials      397      396       -1
Impacted Files Coverage Δ
core/sequencer/server.go 71.14% <0%> (ø) ⬆️
core/sequencer/trillian_client.go 62.85% <0%> (+1.42%) ⬆️
impl/sql/directory/storage.go 69.17% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addbb26...38c3260. Read the comment docs.

@n2vi
n2vi approved these changes Nov 22, 2019
@gdbelvin gdbelvin merged commit 56dbae3 into google:master Nov 24, 2019
5 checks passed
5 checks passed
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing addbb26...38c3260
Details
codecov/project 65.99% (+0.07%) compared to addbb26
Details
@gdbelvin gdbelvin deleted the gdbelvin:deps branch Nov 24, 2019
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Dec 10, 2019
* master: (22 commits)
  Enable travis build validation (google#1400)
  Use ProtoEqual for gomock reflection equality (google#1401)
  Fixups for deleted test constructor in trillian repo (google#1398)
  Fix the kubernetes configs (google#1397)
  Upgrade dependencies (google#1387)
  Update install instructions for go 1.13 (google#1388)
  Emit metric with the right dimensions (google#1383)
  Define watermarks as micros (google#1384)
  Library for converting time.Time to sequencer watermarks (google#1381)
  Reduce log spam (google#1382)
  Support and test mutation log queries at intermediate timestamps (google#1380)
  In memory logs implementation (google#1375)
  Fix generic comparisons on protobuf messages (google#1379)
  Do pagination the right way (google#1378)
  Move the responsibility to pick an input log from storage to the frontend (google#1376)
  Init metrics for whole test file (google#1373)
  Break layering violation by using native types (google#1374)
  Switch Timestamp storage to mysql DATETIME (google#1369)
  Use testdb in integration tests (google#1371)
  Use and test the same MySQL connection that main.go uses  (google#1370)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.