Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions for go 1.13 #1388

Merged
merged 2 commits into from Nov 24, 2019

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Nov 22, 2019

No description provided.

gdbelvin added 2 commits Nov 22, 2019
-u is no longer needed now that we have go modules
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Nov 22, 2019
@googlebot googlebot added the cla: yes label Nov 22, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #1388 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   66.02%   65.82%   -0.21%     
==========================================
  Files          52       52              
  Lines        3979     3979              
==========================================
- Hits         2627     2619       -8     
- Misses        957      961       +4     
- Partials      395      399       +4
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-5.72%) ⬇️
core/sequencer/server.go 70.46% <0%> (-1.35%) ⬇️
core/integration/client_tests.go 85.24% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74adc4...eac69d9. Read the comment docs.

@gdbelvin gdbelvin merged commit addbb26 into google:master Nov 24, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 65.82% (-0.21%) compared to b74adc4
Details
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing b74adc4...eac69d9
Details
@gdbelvin gdbelvin deleted the gdbelvin:no_u branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.