Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against fresh builds #1420

Merged
merged 7 commits into from Jan 2, 2020
Merged

Test against fresh builds #1420

merged 7 commits into from Jan 2, 2020

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Dec 28, 2019

  • Build docker images
  • Inject fresh images into kind (k8 in docker)
  • Set docker image tags
gdbelvin added 3 commits Dec 28, 2019
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Dec 28, 2019
@googlebot googlebot added the cla: yes label Dec 28, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #1420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          53       53           
  Lines        3986     3986           
=======================================
  Hits         2637     2637           
  Misses        956      956           
  Partials      393      393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbe72e...c816b16. Read the comment docs.

@gdbelvin gdbelvin force-pushed the gdbelvin:fresh_test branch 2 times, most recently from 7d45337 to 9cbf5cd Dec 31, 2019
@gdbelvin gdbelvin requested review from RJPercival and pavelkalinnikov Dec 31, 2019
Copy link
Contributor

pavelkalinnikov left a comment

LGTM on "I trust you to know what it does" basis. Left a minor edit suggestion.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated
@@ -49,6 +50,7 @@ jobs:
if: branch = master AND type != pull_request
install:
- curl -LO "https://storage.googleapis.com/kubernetes-release/release/v1.16.3/bin/linux/amd64/kubectl" && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash && sudo mv kustomize /usr/local/bin/

This comment has been minimized.

Copy link
@pavelkalinnikov

pavelkalinnikov Jan 2, 2020

Contributor
Suggested change
- curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash && sudo mv kustomize /usr/local/bin/
- curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash && sudo mv kustomize /usr/local/bin/
@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jan 2, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 2, 2020
@gdbelvin gdbelvin force-pushed the gdbelvin:fresh_test branch from 9af0b58 to c87454e Jan 2, 2020
@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jan 2, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 2, 2020
@gdbelvin gdbelvin merged commit e5421fb into google:master Jan 2, 2020
5 checks passed
5 checks passed
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 2fbe72e...c816b16
Details
codecov/project 66.15% remains the same compared to 2fbe72e
Details
@gdbelvin gdbelvin deleted the gdbelvin:fresh_test branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.