Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less flakey codecov #1421

Merged
merged 2 commits into from Jan 15, 2020
Merged

Less flakey codecov #1421

merged 2 commits into from Jan 15, 2020

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Jan 2, 2020

Code coverage seems to bounce around a bit.
Allow it do bounce around by 1% without going red.

@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Jan 2, 2020
@googlebot googlebot added the cla: yes label Jan 2, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1421 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   66.39%   66.31%   -0.08%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
- Hits         2673     2670       -3     
- Misses        960      962       +2     
- Partials      393      394       +1
Impacted Files Coverage Δ
core/sequencer/server.go 72.96% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93eafc9...63d2d44. Read the comment docs.

codecov.yml Outdated Show resolved Hide resolved
@@ -1,3 +1,14 @@
ignore:
- "**/*.pb.go" # ignore generated protos
- "**/*.pb.gw.go" # ignore generated protos
coverage:
range: 60..80

This comment has been minimized.

Copy link
@NatalieDoduc

NatalieDoduc Jan 14, 2020

why an upper bound of 80? or am I misreading this config line?

This comment has been minimized.

Copy link
@gdbelvin

gdbelvin Jan 15, 2020

Author Collaborator

An upper bound of 80 means that code coverage above 80% will be marked as green.
This can be adjusted as the code coverage for the project grows over time.

gdbelvin added 2 commits Jan 2, 2020
@gdbelvin gdbelvin force-pushed the gdbelvin:codecov branch from 309590d to 63d2d44 Jan 15, 2020
@gdbelvin gdbelvin merged commit f7c27c5 into google:master Jan 15, 2020
5 checks passed
5 checks passed
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 93eafc9...63d2d44
Details
codecov/project 66.31% (-0.08%) compared to 93eafc9
Details
@gdbelvin gdbelvin deleted the gdbelvin:codecov branch Jan 15, 2020
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jan 15, 2020
* master:
  Less flakey codecov (google#1421)
  Cleanup old docker images (google#1430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.