Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker HEALTHCHECK #1427

Merged
merged 12 commits into from Jan 8, 2020
Merged

Fix Docker HEALTHCHECK #1427

merged 12 commits into from Jan 8, 2020

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Jan 7, 2020

  • cmd/healthcheck binary to make http(s) requests.
  • Move HEALTHCHECK to Dockerfile
  • Verify health in test scripts
  • Remove unsupported Trillian health checks #1200
gdbelvin added 6 commits Jan 7, 2020
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Jan 7, 2020
@googlebot googlebot added the cla: yes label Jan 7, 2020
@gdbelvin gdbelvin requested a review from RJPercival Jan 7, 2020
cmd/healthcheck/main.go Outdated Show resolved Hide resolved
cmd/healthcheck/main.go Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #1427 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
+ Coverage   66.31%   66.49%   +0.17%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
+ Hits         2670     2677       +7     
+ Misses        962      958       -4     
+ Partials      394      391       -3
Impacted Files Coverage Δ
core/integration/client_tests.go 85.24% <0%> (+0.46%) ⬆️
core/sequencer/server.go 74.59% <0%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e771a6c...fd1640e. Read the comment docs.

gdbelvin added 3 commits Jan 7, 2020
Fixes #1200
Copy link
Member

RJPercival left a comment

Could you update the PR description to say why you're doing this please?

cmd/keytransparency-server/Dockerfile Show resolved Hide resolved
cmd/keytransparency-sequencer/Dockerfile Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
cmd/healthcheck/main.go Outdated Show resolved Hide resolved
cmd/healthcheck/main.go Outdated Show resolved Hide resolved
cmd/healthcheck/main.go Show resolved Hide resolved
@RJPercival RJPercival assigned gdbelvin and unassigned RJPercival Jan 8, 2020
gdbelvin added 3 commits Jan 8, 2020
* master:
  Fix scripts to not depend on KT being in $GOPATH (#1428)
  Fix permissions on Prometheus config files (#1429)
@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

gdbelvin commented Jan 8, 2020

Updated to address comments

@gdbelvin gdbelvin merged commit 68e4b31 into google:master Jan 8, 2020
5 checks passed
5 checks passed
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing e771a6c...fd1640e
Details
codecov/project 66.49% (+0.17%) compared to e771a6c
Details
@gdbelvin gdbelvin deleted the gdbelvin:healthcheck branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.