Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions on Prometheus config files #1429

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@RJPercival
Copy link
Member

RJPercival commented Jan 8, 2020

Prometheus runs as nobody, which meant it couldn't read the config files in /etc/prometheus. Change ownership of the files we place there so that it can read them.

Prometheus runs as nobody, which meant it couldn't read the config
files in /etc/prometheus. Change ownership of the files we place there
so that it can read them.
@RJPercival RJPercival added the bug label Jan 8, 2020
@RJPercival RJPercival requested a review from google/keytransparency as a code owner Jan 8, 2020
@googlebot googlebot added the cla: yes label Jan 8, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files          54       54           
  Lines        4026     4026           
=======================================
  Hits         2670     2670           
  Misses        962      962           
  Partials      394      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926eef1...0e30c92. Read the comment docs.

@gdbelvin gdbelvin merged commit 610bdd3 into google:master Jan 8, 2020
6 checks passed
6 checks passed
DEP All dependencies are resolved
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 926eef1...0e30c92
Details
codecov/project 66.31% remains the same compared to 926eef1
Details
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jan 8, 2020
* master:
  Fix scripts to not depend on KT being in $GOPATH (google#1428)
  Fix permissions on Prometheus config files (google#1429)
@RJPercival RJPercival deleted the RJPercival:prom_cfg branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.