Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove objecthash dependency #1441

Merged
merged 1 commit into from Jan 23, 2020
Merged

Remove objecthash dependency #1441

merged 1 commit into from Jan 23, 2020

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Jan 23, 2020

The last use of object hash was used to pin the config in the
gobindclient. Rather than hashing the config, future versions of the
client should either build in a static config, or supply it direclty

The last use of object hash was used to pin the config in the
gobindclient. Rather than hashing the config, future versions of the
client should either build in a static config, or supply it direclty
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Jan 23, 2020
@gdbelvin gdbelvin requested a review from Mercurrent Jan 23, 2020
@googlebot googlebot added the cla: yes label Jan 23, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #1441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1441   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files          54       54           
  Lines        4026     4026           
=======================================
  Hits         2670     2670           
  Misses        962      962           
  Partials      394      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad57ca8...5b9fbca. Read the comment docs.

@gdbelvin gdbelvin merged commit d8831a2 into google:master Jan 23, 2020
6 checks passed
6 checks passed
DEP All dependencies are resolved
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing ad57ca8...5b9fbca
Details
codecov/project 66.31% remains the same compared to ad57ca8
Details
@gdbelvin gdbelvin deleted the gdbelvin:rm_obj branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.