Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable docker images cleanup script #1445

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Feb 3, 2020

Support running the cleanup script on both mac and linux.
gnudate on mac is gdate, while it is date on linux.

Also separate the cleanup script so deployments can be run in smaller steps.

Support running the cleanup script on both mac and linux.
gnudate on mac is `gdate`, while it is `date` on linux.

Also separate the cleanup script so deployments can be run piecemeal
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Feb 3, 2020
@gdbelvin gdbelvin requested a review from taknira Feb 3, 2020
@googlebot googlebot added the cla: yes label Feb 3, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1445 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1445     +/-   ##
=========================================
- Coverage   66.49%   66.39%   -0.1%     
=========================================
  Files          54       54             
  Lines        4026     4026             
=========================================
- Hits         2677     2673      -4     
- Misses        958      960      +2     
- Partials      391      393      +2
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-2.86%) ⬇️
core/sequencer/server.go 73.94% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50329f2...f53709a. Read the comment docs.

@taknira
taknira approved these changes Feb 5, 2020
@gdbelvin gdbelvin merged commit ab27b74 into google:master Feb 5, 2020
6 checks passed
6 checks passed
DEP All dependencies are resolved
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 50329f2...f53709a
Details
codecov/project Absolute coverage decreased by -0.1, only covered lines were removed
Details
@gdbelvin gdbelvin deleted the gdbelvin:cleanup branch Feb 5, 2020
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 5, 2020
* master:
  Portable docker images cleanup script (google#1445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.