Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
ForceMaster election library #1453
The previous NoopElection broke the API contract of the election factory
This PR introduces a new
@@ Coverage Diff @@ ## master #1453 +/- ## ========================================== + Coverage 66.59% 67.95% +1.36% ========================================== Files 54 54 Lines 4026 4026 ========================================== + Hits 2681 2736 +55 + Misses 956 890 -66 - Partials 389 400 +11
The previous NoopElection broke the API contract of the election factory because it did not cancel contexts upon resigning. As a result, the KT sequencer hung attempting to resign mastership. This PR introduces a new `forcemaster.Election` which respects the election API, and tests it against the `election.Tracker`.
ForceMaster is for deployments that don't have etcd for mastership…
On Thu, Feb 13, 2020 at 5:35 PM Tatiana Merkulova ***@***.***> wrote: *@Mercurrent* approved this pull request. Why ForceMaster? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1453?email_source=notifications&email_token=AABQOTXL7TEFUNRU6W37673RCWAF7A5CNFSM4KUWUM52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVOP4HI#pullrequestreview-358415901>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQOTR7DEIHAMR4YRJTP3TRCWAF7ANCNFSM4KUWUM5Q> .