Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent protobuf nil pointer dereference #600
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
Jun 7, 2017
Collaborator
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov-io
Jun 7, 2017
Codecov Report
Merging #600 into master will not change coverage.
The diff coverage is0%.
@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 32 32
Lines 2566 2566
=======================================
Hits 1254 1254
Misses 1121 1121
Partials 191 191| Impacted Files | Coverage Δ | |
|---|---|---|
| core/client/kt/verify.go | 18.42% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 1518a26...1d74364. Read the comment docs.
codecov-io
commented
Jun 7, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 32 32
Lines 2566 2566
=======================================
Hits 1254 1254
Misses 1121 1121
Partials 191 191
Continue to review full report at Codecov.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
CLAs look good, thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Updated email address in the commits. |
| @@ -6,5 +6,6 @@ | ||
| # Name or Organization <email address> | ||
| # The email address is not required for organizations. | ||
| Antonio Marcedone <a.marcedone@gmail.com> |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gdbelvin
self-requested a review
Jun 9, 2017
gdbelvin
requested changes
Jun 9, 2017
Thanks for your first PR!
Please add a description to the commit and alphabetize the AUTHORS and CONTRIBUTORS files
gdbelvin
requested changes
Jun 14, 2017
This looks good.
Please adjust the AUTHORS file when you hear back from management.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Bump? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
AMarcedone
Jun 19, 2017
Contributor
|
Still waiting on this CLA, sorry!
…On Mon, Jun 19, 2017 at 3:54 AM Gary Belvin ***@***.***> wrote:
Bump?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#600 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIpjZdiqGigT_Taj8_Vcpssx-cH9Zadiks5sFlNTgaJpZM4NyETX>
.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Let me know if there's anything we can do on our side to help. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
AMarcedone
Jul 7, 2017
Contributor
|
Update: I am still trying to get this CLA issues resolved asap.
Sorry for the delay.
…On Tue, Jun 20, 2017 at 1:47 AM Gary Belvin ***@***.***> wrote:
Let me know if there's anything we can do on our side to help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#600 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIpjZfJ-J_7mBPAz4QBIQlFZ11SigxaZks5sF4cDgaJpZM4NyETX>
.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks Antonio we look forward to working together! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Happy to merge now if you update :-) |
AMarcedone
added some commits
May 26, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Updated :) |
AMarcedone commentedJun 7, 2017
No description provided.