New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent protobuf nil pointer dereference #600

Merged
merged 4 commits into from Aug 8, 2017

Conversation

Projects
None yet
4 participants
@AMarcedone
Contributor

AMarcedone commented Jun 7, 2017

No description provided.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Jun 7, 2017

Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Collaborator

googlebot commented Jun 7, 2017

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 7, 2017

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          32       32           
  Lines        2566     2566           
=======================================
  Hits         1254     1254           
  Misses       1121     1121           
  Partials      191      191
Impacted Files Coverage Δ
core/client/kt/verify.go 18.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1518a26...1d74364. Read the comment docs.

codecov-io commented Jun 7, 2017

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          32       32           
  Lines        2566     2566           
=======================================
  Hits         1254     1254           
  Misses       1121     1121           
  Partials      191      191
Impacted Files Coverage Δ
core/client/kt/verify.go 18.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1518a26...1d74364. Read the comment docs.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Jun 7, 2017

Collaborator

CLAs look good, thanks!

Collaborator

googlebot commented Jun 7, 2017

CLAs look good, thanks!

@AMarcedone

This comment has been minimized.

Show comment
Hide comment
@AMarcedone

AMarcedone Jun 7, 2017

Contributor

Updated email address in the commits.

Contributor

AMarcedone commented Jun 7, 2017

Updated email address in the commits.

@@ -6,5 +6,6 @@
# Name or Organization <email address>
# The email address is not required for organizations.
Antonio Marcedone <a.marcedone@gmail.com>

This comment has been minimized.

@gdbelvin

gdbelvin Jun 9, 2017

Collaborator

This should be Snap or Snap Inc.
Also, please alphabetize

@gdbelvin

gdbelvin Jun 9, 2017

Collaborator

This should be Snap or Snap Inc.
Also, please alphabetize

Show outdated Hide outdated CONTRIBUTORS

@gdbelvin gdbelvin self-requested a review Jun 9, 2017

@gdbelvin

Thanks for your first PR!
Please add a description to the commit and alphabetize the AUTHORS and CONTRIBUTORS files 👍

@gdbelvin

This looks good.
Please adjust the AUTHORS file when you hear back from management.

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Jun 19, 2017

Collaborator

Bump?

Collaborator

gdbelvin commented Jun 19, 2017

Bump?

@AMarcedone

This comment has been minimized.

Show comment
Hide comment
@AMarcedone

AMarcedone Jun 19, 2017

Contributor
Contributor

AMarcedone commented Jun 19, 2017

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Jun 20, 2017

Collaborator

Let me know if there's anything we can do on our side to help.

Collaborator

gdbelvin commented Jun 20, 2017

Let me know if there's anything we can do on our side to help.

@AMarcedone

This comment has been minimized.

Show comment
Hide comment
@AMarcedone

AMarcedone Jul 7, 2017

Contributor
Contributor

AMarcedone commented Jul 7, 2017

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Jul 7, 2017

Collaborator

Thanks Antonio we look forward to working together!

Collaborator

gdbelvin commented Jul 7, 2017

Thanks Antonio we look forward to working together!

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Aug 4, 2017

Collaborator

Happy to merge now if you update :-)

Collaborator

gdbelvin commented Aug 4, 2017

Happy to merge now if you update :-)

@AMarcedone

This comment has been minimized.

Show comment
Hide comment
@AMarcedone

AMarcedone Aug 4, 2017

Contributor

Updated :)

Contributor

AMarcedone commented Aug 4, 2017

Updated :)

@gdbelvin

LGTM

@gdbelvin gdbelvin merged commit a829e3c into google:master Aug 8, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment