Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Prevent protobuf nil pointer dereference #600

Merged

Conversation

AMarcedone
Copy link
Contributor

No description provided.

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@codecov-io
Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          32       32           
  Lines        2566     2566           
=======================================
  Hits         1254     1254           
  Misses       1121     1121           
  Partials      191      191
Impacted Files Coverage Δ
core/client/kt/verify.go 18.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1518a26...1d74364. Read the comment docs.

@AMarcedone AMarcedone force-pushed the preventProtobufNilPointerDereference branch from 26caac4 to c461db0 Compare Jun 7, 2017
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@AMarcedone
Copy link
Contributor Author

Updated email address in the commits.

@@ -6,5 +6,6 @@
# Name or Organization <email address>
# The email address is not required for organizations.

Antonio Marcedone <a.marcedone@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Snap or Snap Inc.
Also, please alphabetize

CONTRIBUTORS Outdated
@@ -9,6 +9,7 @@
# Names should be added to this file as:
# Name <email address>

Antonio Marcedone <a.marcedone@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize

@gdbelvin gdbelvin self-requested a review Jun 9, 2017
Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR!
Please add a description to the commit and alphabetize the AUTHORS and CONTRIBUTORS files 👍

@AMarcedone AMarcedone force-pushed the preventProtobufNilPointerDereference branch from c461db0 to 91ffd42 Compare Jun 9, 2017
Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
Please adjust the AUTHORS file when you hear back from management.

@gdbelvin
Copy link
Contributor

Bump?

@AMarcedone
Copy link
Contributor Author

AMarcedone commented Jun 19, 2017 via email

@gdbelvin
Copy link
Contributor

Let me know if there's anything we can do on our side to help.

@AMarcedone
Copy link
Contributor Author

AMarcedone commented Jul 7, 2017 via email

@gdbelvin
Copy link
Contributor

gdbelvin commented Jul 7, 2017

Thanks Antonio we look forward to working together!

@gdbelvin
Copy link
Contributor

gdbelvin commented Aug 4, 2017

Happy to merge now if you update :-)

@AMarcedone AMarcedone force-pushed the preventProtobufNilPointerDereference branch from ffab439 to 1d74364 Compare Aug 4, 2017
@AMarcedone
Copy link
Contributor Author

Updated :)

Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdbelvin gdbelvin merged commit a829e3c into google:master Aug 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants