Skip to content

/ keytransparency

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent protobuf nil pointer dereference #600

Merged
merged 4 commits into from Aug 8, 2017
Merged

Prevent protobuf nil pointer dereference #600

merged 4 commits into from Aug 8, 2017

Conversation

@AMarcedone
Copy link
Contributor

AMarcedone commented Jun 7, 2017

No description provided.

@googlebot
Copy link
Collaborator

googlebot commented Jun 7, 2017

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@codecov-io
Copy link

codecov-io commented Jun 7, 2017 •
edited

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          32       32           
  Lines        2566     2566           
=======================================
  Hits         1254     1254           
  Misses       1121     1121           
  Partials      191      191
Impacted Files Coverage Δ
core/client/kt/verify.go 18.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1518a26...1d74364. Read the comment docs.
@AMarcedone AMarcedone force-pushed the AMarcedone:preventProtobufNilPointerDereference branch from 26caac4 to c461db0 Jun 7, 2017
@googlebot
Copy link
Collaborator

googlebot commented Jun 7, 2017

CLAs look good, thanks!
@AMarcedone
Copy link
Contributor Author

AMarcedone commented Jun 7, 2017

Updated email address in the commits.
@gdbelvin
gdbelvin reviewed Jun 9, 2017
View changes
AUTHORS
@@ -6,5 +6,6 @@
# Name or Organization <email address>
# The email address is not required for organizations.

Antonio Marcedone <a.marcedone@gmail.com>

This comment has been minimized.

Sign in to view
@gdbelvin

gdbelvin Jun 9, 2017 Contributor

This should be Snap or Snap Inc.
Also, please alphabetize
@gdbelvin
gdbelvin reviewed Jun 9, 2017
View changes
CONTRIBUTORS Outdated
@@ -9,6 +9,7 @@
# Names should be added to this file as:
# Name <email address>

Antonio Marcedone <a.marcedone@gmail.com>

This comment has been minimized.

Sign in to view
@gdbelvin

gdbelvin Jun 9, 2017 Contributor

Please alphabetize
@gdbelvin gdbelvin self-requested a review Jun 9, 2017
@gdbelvin
gdbelvin suggested changes Jun 9, 2017
View changes
Copy link
Contributor

gdbelvin left a comment

Thanks for your first PR!
Please add a description to the commit and alphabetize the AUTHORS and CONTRIBUTORS files 👍
@AMarcedone AMarcedone force-pushed the AMarcedone:preventProtobufNilPointerDereference branch from c461db0 to 91ffd42 Jun 9, 2017
@gdbelvin
gdbelvin suggested changes Jun 14, 2017
View changes
Copy link
Contributor

gdbelvin left a comment

This looks good.
Please adjust the AUTHORS file when you hear back from management.
@gdbelvin
Copy link
Contributor

gdbelvin commented Jun 19, 2017

Bump?
@AMarcedone
Copy link
Contributor Author

AMarcedone commented Jun 19, 2017

@gdbelvin
Copy link
Contributor

gdbelvin commented Jun 20, 2017

Let me know if there's anything we can do on our side to help.
@AMarcedone
Copy link
Contributor Author

AMarcedone commented Jul 7, 2017

@gdbelvin
Copy link
Contributor

gdbelvin commented Jul 7, 2017

Thanks Antonio we look forward to working together!
@gdbelvin
Copy link
Contributor

gdbelvin commented Aug 4, 2017

Happy to merge now if you update :-)
AMarcedone added 4 commits May 26, 2017
@AMarcedone
Fix minor typo
Loading status checks…
3e21e7c
@AMarcedone
Update verify.go to use getters for accessing protobuf to prevent nil…
Loading status checks…
80f0f81 
… pointer dereference when fields are nil
@AMarcedone
Add myself to AUTHORS and CONTRIBUTORS
Loading status checks…
53a649c
@AMarcedone
Alphabetize CONTRIBUTORS
Loading status checks…
1d74364
@AMarcedone AMarcedone force-pushed the AMarcedone:preventProtobufNilPointerDereference branch from ffab439 to 1d74364 Aug 4, 2017
@AMarcedone
Copy link
Contributor Author

AMarcedone commented Aug 4, 2017

Updated :)
@gdbelvin
gdbelvin approved these changes Aug 7, 2017
View changes
Copy link
Contributor

gdbelvin left a comment

LGTM
@gdbelvin gdbelvin merged commit a829e3c into google:master Aug 8, 2017
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdbelvin gdbelvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@AMarcedone @googlebot @codecov-io @gdbelvin
You can’t perform that action at this time.