Prevent protobuf nil pointer dereference #600
Prevent protobuf nil pointer dereference #600
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 32 32
Lines 2566 2566
=======================================
Hits 1254 1254
Misses 1121 1121
Partials 191 191
Continue to review full report at Codecov.
|
26caac4
to
c461db0
Compare
CLAs look good, thanks! |
Updated email address in the commits. |
@@ -6,5 +6,6 @@ | |||
# Name or Organization <email address> | |||
# The email address is not required for organizations. | |||
|
|||
Antonio Marcedone <a.marcedone@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Snap or Snap Inc.
Also, please alphabetize
CONTRIBUTORS
Outdated
@@ -9,6 +9,7 @@ | |||
# Names should be added to this file as: | |||
# Name <email address> | |||
|
|||
Antonio Marcedone <a.marcedone@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please alphabetize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first PR!
Please add a description to the commit and alphabetize the AUTHORS and CONTRIBUTORS files
c461db0
to
91ffd42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Please adjust the AUTHORS file when you hear back from management.
Bump? |
Still waiting on this CLA, sorry!
…On Mon, Jun 19, 2017 at 3:54 AM Gary Belvin ***@***.***> wrote:
Bump?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#600 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIpjZdiqGigT_Taj8_Vcpssx-cH9Zadiks5sFlNTgaJpZM4NyETX>
.
|
Let me know if there's anything we can do on our side to help. |
Update: I am still trying to get this CLA issues resolved asap.
Sorry for the delay.
…On Tue, Jun 20, 2017 at 1:47 AM Gary Belvin ***@***.***> wrote:
Let me know if there's anything we can do on our side to help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#600 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIpjZfJ-J_7mBPAz4QBIQlFZ11SigxaZks5sF4cDgaJpZM4NyETX>
.
|
Thanks Antonio we look forward to working together! |
Happy to merge now if you update :-) |
… pointer dereference when fields are nil
ffab439
to
1d74364
Compare
Updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.