New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .dockerignore file #622

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
3 participants
@Liamsi
Contributor

Liamsi commented Jun 20, 2017

and move gcloud auth command from the deploy script to travis, delete secret_key after usage (so it doesn't end up in docker images)

resolves #623

@Liamsi Liamsi requested review from gdbelvin and cesarghali Jun 20, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 20, 2017

Codecov Report

Merging #622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   57.21%   57.21%           
=======================================
  Files          35       35           
  Lines        2489     2489           
=======================================
  Hits         1424     1424           
  Misses        776      776           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9049287...8c74e36. Read the comment docs.

codecov-io commented Jun 20, 2017

Codecov Report

Merging #622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   57.21%   57.21%           
=======================================
  Files          35       35           
  Lines        2489     2489           
=======================================
  Hits         1424     1424           
  Misses        776      776           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9049287...8c74e36. Read the comment docs.

@Liamsi Liamsi merged commit b48c0d1 into google:master Jun 20, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment