New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: keytransparency-signer to keytransparency-sequencer #764

Merged
merged 6 commits into from Aug 18, 2017

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Aug 18, 2017

After the migration to Trillian, the keytransparency-signer doesn't actually sign anything anymore.
Therefore it makes sense to give it a new name for it's real job: sequencing and batching mutations into Map Revisions.

@gdbelvin gdbelvin requested review from cesarghali, taknira and Liamsi Aug 18, 2017

@google google deleted a comment from codecov-io Aug 18, 2017

@Liamsi

Liamsi suggested changes Aug 18, 2017 edited

PLease rebaseon /merge with master and remove the keytransparency-signer binary from the repo:
https://github.com/gdbelvin/keytransparency/blob/eda3058df1a1c518719700608ad5cce47828c953/keytransparency-signer
Besides that LGTM

@@ -3,7 +3,7 @@
*~
/keytransparency-server
/keytransparency-signer
/keytransparency-sequencer

This comment has been minimized.

@Liamsi

Liamsi Aug 18, 2017

Contributor

Due to this change the keytransparency-signer binary made it into the repo.

@Liamsi

Liamsi Aug 18, 2017

Contributor

Due to this change the keytransparency-signer binary made it into the repo.

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Aug 18, 2017

Collaborator

Updated PTAL

Collaborator

gdbelvin commented Aug 18, 2017

Updated PTAL

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 18, 2017

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is 12.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   48.42%   48.42%           
=======================================
  Files          28       28           
  Lines        2480     2480           
=======================================
  Hits         1201     1201           
  Misses       1093     1093           
  Partials      186      186
Impacted Files Coverage Δ
core/sequencer/sequencer.go 9.44% <0%> (ø)
integration/testutil.go 68.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ef412...f8ad647. Read the comment docs.

codecov-io commented Aug 18, 2017

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is 12.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   48.42%   48.42%           
=======================================
  Files          28       28           
  Lines        2480     2480           
=======================================
  Hits         1201     1201           
  Misses       1093     1093           
  Partials      186      186
Impacted Files Coverage Δ
core/sequencer/sequencer.go 9.44% <0%> (ø)
integration/testutil.go 68.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ef412...f8ad647. Read the comment docs.

@Liamsi

Liamsi approved these changes Aug 18, 2017

LGTM

@gdbelvin gdbelvin merged commit 8eb3a9a into google:master Aug 18, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:refactor/signer branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment