Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor verification logic #768

Merged
merged 10 commits into from Sep 1, 2017
Merged

Monitor verification logic #768

merged 10 commits into from Sep 1, 2017

Conversation

@liamsi
Copy link
Contributor

liamsi commented Aug 18, 2017

This PR contains the monitor verification logic which should be plugged into the monitor after #776 is merged.

Includes a fix for #800 and related to this a temporary workaround for #811.

resolves #800

@liamsi liamsi added the WIP label Aug 18, 2017
liamsi added a commit to liamsi/keytransparency that referenced this pull request Aug 18, 2017
@liamsi liamsi force-pushed the liamsi:monitor_verification branch 2 times, most recently from b4b52aa to 2152cd4 Aug 23, 2017
@google google deleted a comment from codecov-io Aug 24, 2017
@liamsi liamsi added this to In Progress in Hackathon 2017 Aug 24, 2017
@liamsi liamsi force-pushed the liamsi:monitor_verification branch from 74e145c to e6e9a7d Aug 24, 2017
@liamsi liamsi mentioned this pull request Aug 25, 2017
liamsi added 8 commits Aug 23, 2017
@liamsi liamsi force-pushed the liamsi:monitor_verification branch 2 times, most recently from adda848 to 174ca9b Aug 31, 2017
@liamsi liamsi requested a review from cesarghali Aug 31, 2017
@liamsi liamsi removed the WIP label Aug 31, 2017
@liamsi liamsi force-pushed the liamsi:monitor_verification branch from 174ca9b to c64534b Aug 31, 2017
@liamsi liamsi force-pushed the liamsi:monitor_verification branch from c64534b to 67c526e Aug 31, 2017
@liamsi liamsi moved this from In Progress to Awaiting Review in Hackathon 2017 Aug 31, 2017
Copy link
Collaborator

cesarghali left a comment

With few nits.

"math/big"

"github.com/golang/glog"

This comment has been minimized.

@cesarghali

cesarghali Aug 31, 2017 Collaborator

Please remove empty line.


"github.com/google/trillian/merkle"
"github.com/google/trillian/storage"

This comment has been minimized.

@cesarghali

cesarghali Aug 31, 2017 Collaborator

Please remove empty line.


tcrypto "github.com/google/trillian/crypto"

"github.com/google/keytransparency/core/mutator/entry"

This comment has been minimized.

@cesarghali

cesarghali Aug 31, 2017 Collaborator

Move this to the second section of the imports:

  • Standard packages.
  • KT packages.
  • Others.
  • Protos.
@liamsi liamsi force-pushed the liamsi:monitor_verification branch from ed65fb1 to d1e6aea Aug 31, 2017
@google google deleted a comment from codecov-io Aug 31, 2017
@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #768 into master will decrease coverage by 1.83%.
The diff coverage is 11.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   47.25%   45.41%   -1.84%     
==========================================
  Files          34       34              
  Lines        2588     2717     +129     
==========================================
+ Hits         1223     1234      +11     
- Misses       1178     1295     +117     
- Partials      187      188       +1
Impacted Files Coverage Δ
core/monitor/verify.go 0% <0%> (ø) ⬆️
core/monitor/monitor.go 0% <0%> (ø) ⬆️
core/mutation/mutation.go 62% <100%> (+1.58%) ⬆️
integration/testutil.go 66.16% <72.72%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a237b6...d1e6aea. Read the comment docs.

@liamsi liamsi merged commit 9b99af5 into google:master Sep 1, 2017
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@liamsi liamsi moved this from Awaiting Review to Merged in Hackathon 2017 Sep 1, 2017
@liamsi liamsi mentioned this pull request Sep 1, 2017
@liamsi liamsi added this to the Build Monitor milestone Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.