Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Monitor verification logic #768

Merged
merged 10 commits into from Sep 1, 2017
Merged

Conversation

liamsi
Copy link
Contributor

@liamsi liamsi commented Aug 18, 2017

This PR contains the monitor verification logic which should be plugged into the monitor after #776 is merged.

Includes a fix for #800 and related to this a temporary workaround for #811.

resolves #800

@liamsi liamsi added the WIP label Aug 18, 2017
liamsi added a commit to liamsi/keytransparency that referenced this pull request Aug 18, 2017
@liamsi liamsi force-pushed the monitor_verification branch 2 times, most recently from b4b52aa to 2152cd4 Compare August 24, 2017 12:25
@google google deleted a comment from codecov-io Aug 24, 2017
@liamsi liamsi added this to In Progress in Hackathon 2017 Aug 24, 2017
@liamsi liamsi mentioned this pull request Aug 25, 2017
@liamsi liamsi force-pushed the monitor_verification branch 2 times, most recently from adda848 to 174ca9b Compare August 31, 2017 12:14
@liamsi liamsi requested a review from cesarghali August 31, 2017 12:29
@liamsi liamsi removed the WIP label Aug 31, 2017
@liamsi liamsi moved this from In Progress to Awaiting Review in Hackathon 2017 Aug 31, 2017
Copy link
Collaborator

@cesarghali cesarghali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With few nits.

"math/big"

"github.com/golang/glog"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty line.


"github.com/google/trillian/merkle"
"github.com/google/trillian/storage"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty line.


tcrypto "github.com/google/trillian/crypto"

"github.com/google/keytransparency/core/mutator/entry"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the second section of the imports:

  • Standard packages.
  • KT packages.
  • Others.
  • Protos.

@google google deleted a comment from codecov-io Aug 31, 2017
@codecov-io
Copy link

Codecov Report

Merging #768 into master will decrease coverage by 1.83%.
The diff coverage is 11.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   47.25%   45.41%   -1.84%     
==========================================
  Files          34       34              
  Lines        2588     2717     +129     
==========================================
+ Hits         1223     1234      +11     
- Misses       1178     1295     +117     
- Partials      187      188       +1
Impacted Files Coverage Δ
core/monitor/verify.go 0% <0%> (ø) ⬆️
core/monitor/monitor.go 0% <0%> (ø) ⬆️
core/mutation/mutation.go 62% <100%> (+1.58%) ⬆️
integration/testutil.go 66.16% <72.72%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a237b6...d1e6aea. Read the comment docs.

@liamsi liamsi merged commit 9b99af5 into google:master Sep 1, 2017
@liamsi liamsi moved this from Awaiting Review to Merged in Hackathon 2017 Sep 1, 2017
@liamsi liamsi mentioned this pull request Sep 1, 2017
@liamsi liamsi added this to the Build Monitor milestone Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Mutator returns inclusion proof in wrong epoch
3 participants