Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMonitor verification logic #768
Merged
Conversation
liamsi
added a commit
to liamsi/keytransparency
that referenced
this pull request
Aug 18, 2017
liamsi
force-pushed the
liamsi:monitor_verification
branch
2 times, most recently
from
b4b52aa
to
2152cd4
Merged
liamsi
force-pushed the
liamsi:monitor_verification
branch
2 times, most recently
from
adda848
to
174ca9b
|
With few nits. |
core/monitor/verify.go
Outdated
| "math/big" | ||
|
|
||
| "github.com/golang/glog" | ||
|
|
This comment has been minimized.
This comment has been minimized.
core/monitor/verify.go
Outdated
|
|
||
| "github.com/google/trillian/merkle" | ||
| "github.com/google/trillian/storage" | ||
|
|
This comment has been minimized.
This comment has been minimized.
core/monitor/verify.go
Outdated
|
|
||
| tcrypto "github.com/google/trillian/crypto" | ||
|
|
||
| "github.com/google/keytransparency/core/mutator/entry" |
This comment has been minimized.
This comment has been minimized.
cesarghali
Aug 31, 2017
Collaborator
Move this to the second section of the imports:
- Standard packages.
- KT packages.
- Others.
- Protos.
codecov-io
commented
Sep 1, 2017
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 47.25% 45.41% -1.84%
==========================================
Files 34 34
Lines 2588 2717 +129
==========================================
+ Hits 1223 1234 +11
- Misses 1178 1295 +117
- Partials 187 188 +1
Continue to review full report at Codecov.
|
liamsi
merged commit 9b99af5
into
google:master
2 checks passed
2 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
liamsi commentedAug 18, 2017
•
edited
This PR contains the monitor verification logic which should be plugged into the monitor after #776 is merged.
Includes a fix for #800 and related to this a temporary workaround for #811.
resolves #800