Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMonitor verification logic #768
Conversation
Liamsi
added
the
WIP
label
Aug 18, 2017
added a commit
to Liamsi/keytransparency
that referenced
this pull request
Aug 18, 2017
Liamsi
referenced this pull request
Aug 23, 2017
Open
Monitor: kubernets config and deploy script #787
google
deleted a comment from
codecov-io
Aug 24, 2017
Liamsi
added this to In Progress
in Hackathon 2017
Aug 24, 2017
Liamsi
added some commits
Aug 23, 2017
Liamsi
requested a review
from
cesarghali
Aug 31, 2017
Liamsi
removed
the
WIP
label
Aug 31, 2017
Liamsi
moved this from In Progress
to Awaiting Review
in Hackathon 2017
Aug 31, 2017
google
deleted a comment from
codecov-io
Aug 31, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
codecov-io
Sep 1, 2017
Codecov Report
Merging #768 into master will decrease coverage by
1.83%.
The diff coverage is11.03%.
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 47.25% 45.41% -1.84%
==========================================
Files 34 34
Lines 2588 2717 +129
==========================================
+ Hits 1223 1234 +11
- Misses 1178 1295 +117
- Partials 187 188 +1| Impacted Files | Coverage Δ | |
|---|---|---|
| core/monitor/verify.go | 0% <0%> (ø) |
|
| core/monitor/monitor.go | 0% <0%> (ø) |
|
| core/mutation/mutation.go | 62% <100%> (+1.58%) |
|
| integration/testutil.go | 66.16% <72.72%> (-0.24%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 3a237b6...d1e6aea. Read the comment docs.
codecov-io
commented
Sep 1, 2017
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 47.25% 45.41% -1.84%
==========================================
Files 34 34
Lines 2588 2717 +129
==========================================
+ Hits 1223 1234 +11
- Misses 1178 1295 +117
- Partials 187 188 +1
Continue to review full report at Codecov.
|
Liamsi
merged commit 9b99af5
into
google:master
Sep 1, 2017
2 checks passed
cla/google
All necessary CLAs are signed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Liamsi
moved this from Awaiting Review
to Merged
in Hackathon 2017
Sep 1, 2017
Liamsi
added this to the Build Monitor milestone
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Liamsi commentedAug 18, 2017
•
edited
This PR contains the monitor verification logic which should be plugged into the monitor after #776 is merged.
Includes a fix for #800 and related to this a temporary workaround for #811.
resolves #800