Conversation
b4b52aa
to
2152cd4
Compare
74e145c
to
e6e9a7d
Compare
adda848
to
174ca9b
Compare
174ca9b
to
c64534b
Compare
c64534b
to
67c526e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With few nits.
core/monitor/verify.go
Outdated
"math/big" | ||
|
||
"github.com/golang/glog" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove empty line.
core/monitor/verify.go
Outdated
|
||
"github.com/google/trillian/merkle" | ||
"github.com/google/trillian/storage" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove empty line.
core/monitor/verify.go
Outdated
|
||
tcrypto "github.com/google/trillian/crypto" | ||
|
||
"github.com/google/keytransparency/core/mutator/entry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to the second section of the imports:
- Standard packages.
- KT packages.
- Others.
- Protos.
ed65fb1
to
d1e6aea
Compare
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 47.25% 45.41% -1.84%
==========================================
Files 34 34
Lines 2588 2717 +129
==========================================
+ Hits 1223 1234 +11
- Misses 1178 1295 +117
- Partials 187 188 +1
Continue to review full report at Codecov.
|
This PR contains the monitor verification logic which should be plugged into the monitor after #776 is merged.
Includes a fix for #800 and related to this a temporary workaround for #811.
resolves #800