This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Monitor verification logic #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
added a commit
to liamsi/keytransparency
that referenced
this pull request
Aug 18, 2017
liamsi
force-pushed
the
monitor_verification
branch
2 times, most recently
from
b4b52aa
to
2152cd4
Compare
liamsi
force-pushed
the
monitor_verification
branch
from
74e145c
to
e6e9a7d
Compare
Merged
liamsi
force-pushed
the
monitor_verification
branch
2 times, most recently
from
adda848
to
174ca9b
Compare
liamsi
force-pushed
the
monitor_verification
branch
from
174ca9b
to
c64534b
Compare
liamsi
force-pushed
the
monitor_verification
branch
from
c64534b
to
67c526e
Compare
cesarghali
approved these changes
Aug 31, 2017
core/monitor/verify.go
Outdated
| "math/big" | ||
|
|
||
| "github.com/golang/glog" | ||
|
|
There was a problem hiding this comment.
Please remove empty line.
core/monitor/verify.go
Outdated
|
|
||
| "github.com/google/trillian/merkle" | ||
| "github.com/google/trillian/storage" | ||
|
|
There was a problem hiding this comment.
Please remove empty line.
core/monitor/verify.go
Outdated
|
|
||
| tcrypto "github.com/google/trillian/crypto" | ||
|
|
||
| "github.com/google/keytransparency/core/mutator/entry" |
There was a problem hiding this comment.
Move this to the second section of the imports:
- Standard packages.
- KT packages.
- Others.
- Protos.
liamsi
force-pushed
the
monitor_verification
branch
from
ed65fb1
to
d1e6aea
Compare
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 47.25% 45.41% -1.84%
==========================================
Files 34 34
Lines 2588 2717 +129
==========================================
+ Hits 1223 1234 +11
- Misses 1178 1295 +117
- Partials 187 188 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR contains the monitor verification logic which should be plugged into the monitor after #776 is merged.
Includes a fix for #800 and related to this a temporary workaround for #811.
resolves #800