New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-verifying monitor #776

Merged
merged 46 commits into from Aug 24, 2017

Conversation

Projects
3 participants
@Liamsi
Contributor

Liamsi commented Aug 21, 2017

This PR contains everything a monitor would needs to do besides the verification logic. This PR contains all review comments from: #709

The verification logic comes with a separate PR: #768

Liamsi added some commits Jul 12, 2017

WIP: monitor binary
Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's

Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's

work in progress

addressed some early review comments
revert local changes, add TODOs
simplify monitor Dockerfile (non-opinionated)

add argument to 'prepare script' such that the monitor can contact the
kt-server if it isn't reachable via localhost

add proto messages that proof certain errors occurred

early review comments

add signing capability

move verification into separate function

gofmt

golint / presubmit.sh

regenerate proto with correct dependency versions

add script for generating monitor signing key

Add comments to exported methods

Add "observed at" timestamp, sign the root hash

update test
Add to kubernetes config and deploy script
Minor changes

verify signature on response

resolves #672

Add log sig verification

rebase

wip

WIP

add TODO

remove streaming API (simplifies moving to core)

Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's

Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's

work in progress

revert local changes, add TODOs

simplify monitor Dockerfile (non-opinionated)
Add to kubernetes config and deploy script
Minor changes

verify signature on response

resolves #672

Add log sig verification

rebase

wip

WIP

add TODO

remove streaming API (simplifies moving to core)

Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's

Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's

work in progress

revert local changes, add TODOs

simplify monitor Dockerfile (non-opinionated)

regenerate proto with correct dependency versions
Add to kubernetes config and deploy script

resolves #672

rebase

rebase

=gofmt

WIP
Review comments:
* move monitor service types into separate file
* move verification (wip) into sperate file
* generate and use separate priv. key for signing
* pass pointer of priv key
* unexport verifKeys
* Change mutator interface to accept SignedKV objects directly
* Remove replacer which isn't used anywhere
gofmt
fix some typos
Merge branch 'master' into mvp_monitor
# Conflicts:
#	core/client/kt/requests.go
#	core/mutator/entry/entry.go
#	core/mutator/entry/entry_test.go
#	impl/proto/monitor_v1_service/gen.go

@Liamsi Liamsi requested a review from gdbelvin Aug 21, 2017

@google google deleted a comment from codecov-io Aug 22, 2017

@gdbelvin gdbelvin added this to Awaiting Review in Hackathon 2017 Aug 23, 2017

@gdbelvin gdbelvin moved this from Awaiting Review to Merged in Hackathon 2017 Aug 23, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 24, 2017

Codecov Report

Merging #776 into master will decrease coverage by 1.09%.
The diff coverage is 12.65%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #776     +/-   ##
=========================================
- Coverage   48.14%   47.04%   -1.1%     
=========================================
  Files          28       32      +4     
  Lines        2476     2553     +77     
=========================================
+ Hits         1192     1201      +9     
- Misses       1098     1166     +68     
  Partials      186      186
Impacted Files Coverage Δ
impl/mutation/mutation.go 33.33% <ø> (ø) ⬆️
core/monitor/monitor.go 0% <0%> (ø)
core/monitor/verify.go 0% <0%> (ø)
core/monitor/sign.go 0% <0%> (ø)
impl/monitor/server.go 31.03% <31.03%> (ø)
core/mutation/mutation.go 60.41% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5f639...153d655. Read the comment docs.

codecov-io commented Aug 24, 2017

Codecov Report

Merging #776 into master will decrease coverage by 1.09%.
The diff coverage is 12.65%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #776     +/-   ##
=========================================
- Coverage   48.14%   47.04%   -1.1%     
=========================================
  Files          28       32      +4     
  Lines        2476     2553     +77     
=========================================
+ Hits         1192     1201      +9     
- Misses       1098     1166     +68     
  Partials      186      186
Impacted Files Coverage Δ
impl/mutation/mutation.go 33.33% <ø> (ø) ⬆️
core/monitor/monitor.go 0% <0%> (ø)
core/monitor/verify.go 0% <0%> (ø)
core/monitor/sign.go 0% <0%> (ø)
impl/monitor/server.go 31.03% <31.03%> (ø)
core/mutation/mutation.go 60.41% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5f639...153d655. Read the comment docs.

@Liamsi Liamsi merged commit 205ae4d into google:master Aug 24, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Liamsi Liamsi referenced this pull request Sep 1, 2017

Closed

WIP: minimalistic Monitor #709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment