New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendoring specific logic now that go 1.9 handles it for us #828

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Oct 2, 2017

Previously, we used govendor +local to execute commands on the local keytransparency repo without diving into the vendor folder. This is now the default behavior of the go tools as of go 1.9.

@gdbelvin gdbelvin requested a review from cesarghali Oct 2, 2017

@gdbelvin gdbelvin changed the title from Remove vendoring specific logic now that 1.9 handles it for us to Remove vendoring specific logic now that go 1.9 handles it for us Oct 2, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2017

Codecov Report

Merging #828 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   45.56%   45.56%           
=======================================
  Files          34       34           
  Lines        2739     2739           
=======================================
  Hits         1248     1248           
  Misses       1302     1302           
  Partials      189      189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7f3be...d8e61ba. Read the comment docs.

codecov-io commented Oct 2, 2017

Codecov Report

Merging #828 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   45.56%   45.56%           
=======================================
  Files          34       34           
  Lines        2739     2739           
=======================================
  Hits         1248     1248           
  Misses       1302     1302           
  Partials      189      189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7f3be...d8e61ba. Read the comment docs.

@gdbelvin gdbelvin merged commit faaa8ba into google:master Oct 3, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:travis/19 branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment