New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistake #855

Merged
merged 2 commits into from Nov 14, 2017

Conversation

Projects
None yet
4 participants
@SCKelemen
Contributor

SCKelemen commented Nov 9, 2017

ln174 calculated -> calculate

Fix spelling mistake
ln174 calculated -> calculate
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 9, 2017

Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
Collaborator

googlebot commented Nov 9, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@SCKelemen

This comment has been minimized.

Show comment
Hide comment
@SCKelemen

SCKelemen Nov 9, 2017

Contributor

I signed it!

^this should probably be I've signed it!

Contributor

SCKelemen commented Nov 9, 2017

I signed it!

^this should probably be I've signed it!

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 9, 2017

Collaborator

CLAs look good, thanks!

Collaborator

googlebot commented Nov 9, 2017

CLAs look good, thanks!

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Nov 9, 2017

Collaborator

Thanks for your PR!

It appears that some upstream changes have broken the build. I'll fix them up and merge your PR.

Collaborator

gdbelvin commented Nov 9, 2017

Thanks for your PR!

It appears that some upstream changes have broken the build. I'll fix them up and merge your PR.

@SCKelemen

This comment has been minimized.

Show comment
Hide comment
@SCKelemen

SCKelemen Nov 9, 2017

Contributor

Thanks @gdbelvin

Contributor

SCKelemen commented Nov 9, 2017

Thanks @gdbelvin

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 14, 2017

Codecov Report

Merging #855 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #855   +/-   ##
======================================
  Coverage    46.5%   46.5%           
======================================
  Files          34      34           
  Lines        2834    2834           
======================================
  Hits         1318    1318           
  Misses       1322    1322           
  Partials      194     194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f582ba0...ee0929a. Read the comment docs.

codecov-io commented Nov 14, 2017

Codecov Report

Merging #855 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #855   +/-   ##
======================================
  Coverage    46.5%   46.5%           
======================================
  Files          34      34           
  Lines        2834    2834           
======================================
  Hits         1318    1318           
  Misses       1322    1322           
  Partials      194     194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f582ba0...ee0929a. Read the comment docs.

@gdbelvin gdbelvin merged commit 67f4bed into google:master Nov 14, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SCKelemen SCKelemen deleted the SCKelemen:patch-1 branch Nov 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment