New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored objecthash to e06914f #863

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@phad
Contributor

phad commented Nov 23, 2017

API changes require:

  • client code to CommonJSONify structs, protobufs, etc. before calling
    objecthash.ObjectHash();
  • client code to handle error returns (earlier objecthash would panic).
Update vendored objecthash to e06914f
API changes require:
 * client code to CommonJSONify structs, protobufs, etc. before calling
   objecthash.ObjectHash();
 * client code to handle error returns (earlier objecthash would panic).

@phad phad requested a review from gdbelvin Nov 23, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 23, 2017

Codecov Report

Merging #863 into master will decrease coverage by 0.28%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   45.82%   45.53%   -0.29%     
==========================================
  Files          34       34              
  Lines        2883     2901      +18     
==========================================
  Hits         1321     1321              
- Misses       1368     1380      +12     
- Partials      194      200       +6
Impacted Files Coverage Δ
core/crypto/signatures/p256/ecdsa_p256.go 41.45% <25%> (-1.94%) ⬇️
core/mutator/entry/mutation.go 72% <25%> (-5.95%) ⬇️
core/mutator/entry/mutator.go 72.22% <25%> (-6.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e715077...bcf45b3. Read the comment docs.

codecov-io commented Nov 23, 2017

Codecov Report

Merging #863 into master will decrease coverage by 0.28%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   45.82%   45.53%   -0.29%     
==========================================
  Files          34       34              
  Lines        2883     2901      +18     
==========================================
  Hits         1321     1321              
- Misses       1368     1380      +12     
- Partials      194      200       +6
Impacted Files Coverage Δ
core/crypto/signatures/p256/ecdsa_p256.go 41.45% <25%> (-1.94%) ⬇️
core/mutator/entry/mutation.go 72% <25%> (-5.95%) ⬇️
core/mutator/entry/mutator.go 72.22% <25%> (-6.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e715077...bcf45b3. Read the comment docs.

@gdbelvin

Thanks for this fix!
LGTM

@phad phad merged commit c4b78d6 into google:master Nov 23, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phad phad deleted the phad:ph_update_objecthash branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment