Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
AccountManagerService API #864
This PR creates the
This PR also experiments with bringing the proto directory futher inline with the style guide
This turned into a bit of an impromptu API review, which is not that great for you because 1. I don't think I have enough context about your API and 2. Github is probably not the best place to have this discussion. So, take my comments with a grain of salt. I'm happy to have this discussion in an "informal" review, outside of Github, if you like.
I really like your documentation. It answered all the questions I had.
@@ Coverage Diff @@ ## master #864 +/- ## ========================================== + Coverage 48.78% 48.83% +0.04% ========================================== Files 34 34 Lines 2353 2351 -2 ========================================== Hits 1148 1148 + Misses 1001 999 -2 Partials 204 204
I've added a few API comments / questions. I don't consider any of my comments blocking, so feel free to proceed if you like. Consider this a drive-by review ;)