New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter cleanup GoMetaLinter:gas #866

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@gdbelvin
Collaborator

gdbelvin commented Nov 27, 2017

The Go AST Scanner was recently fixed. This PR makes the needed corrections in this repo.

As a result, the mac firewall will no longer complain when running integration tests!

Linter cleanup GoMetaLinter:gas
The [Go AST Scanner](https://github.com/GoASTScanner/gas)
[recently](alecthomas/gometalinter@3e602d9)
was fixed. This PR makes the needed corrections in this repo.

@gdbelvin gdbelvin requested review from phad and AMarcedone Nov 27, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 27, 2017

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files          34       34           
  Lines        2901     2901           
=======================================
  Hits         1321     1321           
  Misses       1380     1380           
  Partials      200      200
Impacted Files Coverage Δ
integration/testutil.go 65.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1820740...bdfb45f. Read the comment docs.

codecov-io commented Nov 27, 2017

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files          34       34           
  Lines        2901     2901           
=======================================
  Hits         1321     1321           
  Misses       1380     1380           
  Partials      200      200
Impacted Files Coverage Δ
integration/testutil.go 65.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1820740...bdfb45f. Read the comment docs.

@gdbelvin gdbelvin merged commit 8df18ed into google:master Nov 27, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:fix/lint branch Mar 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment