New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetLeavesByRevision to fake.TrillianMapClient #872

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Dec 7, 2017

Also moves the fake TrillianMapClient into core/fake
and cleans up the test to use a proper client interface.

Add GetLeavesByRevision to fake.TrillianMapClient
Also moves the fake TrillianMapClient into core/fake
and cleans up the test to use a proper client interface.

@gdbelvin gdbelvin requested a review from phad Dec 7, 2017

Show outdated Hide outdated core/fake/trillian_map_client.go Outdated
@phad

This comment has been minimized.

Show comment
Hide comment
@phad

phad Dec 7, 2017

Contributor

I was just starting a PR to move the KT code over to use GetLeavesByRevision wherever possible, fixing the fake was part of that ...
I'll drop my fake fix, wait for this to go in, and then continue, ok?

Contributor

phad commented Dec 7, 2017

I was just starting a PR to move the KT code over to use GetLeavesByRevision wherever possible, fixing the fake was part of that ...
I'll drop my fake fix, wait for this to go in, and then continue, ok?

@phad

phad approved these changes Dec 7, 2017

@phad

This comment has been minimized.

Show comment
Hide comment
@phad

phad Dec 7, 2017

Contributor

LGTM, squash and merge

Contributor

phad commented Dec 7, 2017

LGTM, squash and merge

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Dec 7, 2017

Collaborator

Sounds good. This fake needed some love anyways - it just barely does the job.
Changing the rest of the code to use GetLeaves and GetLeavesByRevision sounds good though. (No more pesky revision: -1!!)

Collaborator

gdbelvin commented Dec 7, 2017

Sounds good. This fake needed some love anyways - it just barely does the job.
Changing the rest of the code to use GetLeaves and GetLeavesByRevision sounds good though. (No more pesky revision: -1!!)

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 7, 2017

Codecov Report

Merging #872 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files          34       34           
  Lines        2353     2353           
=======================================
  Hits         1148     1148           
  Misses       1001     1001           
  Partials      204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbe7d5...862c840. Read the comment docs.

codecov-io commented Dec 7, 2017

Codecov Report

Merging #872 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files          34       34           
  Lines        2353     2353           
=======================================
  Hits         1148     1148           
  Misses       1001     1001           
  Partials      204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbe7d5...862c840. Read the comment docs.

@gdbelvin gdbelvin merged commit 0b84de2 into google:master Dec 7, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:fix/faketmap branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment