New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index mutations by domainID #900

Merged
merged 2 commits into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Jan 4, 2018

This PR switches the mutation storage table from using mapID as the primary mutation key and replaces it with domainID. This achieves a slightly cleaner abstraction and brings internal and external APIs into alignment.

@gdbelvin gdbelvin requested review from phad and cesarghali Jan 4, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 4, 2018

Codecov Report

Merging #900 into master will increase coverage by 0.08%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   52.79%   52.87%   +0.08%     
==========================================
  Files          34       34              
  Lines        2288     2292       +4     
==========================================
+ Hits         1208     1212       +4     
  Misses        874      874              
  Partials      206      206
Impacted Files Coverage Δ
core/keyserver/keyserver.go 0% <0%> (ø) ⬆️
core/keyserver/epochs.go 39.58% <100%> (ø) ⬆️
impl/sql/mutationstorage/mutations.go 64.38% <100%> (ø) ⬆️
impl/sql/domain/storage.go 69.47% <100%> (ø) ⬆️
impl/sql/mutationstorage/queue.go 78.12% <100%> (ø) ⬆️
core/adminserver/admin_server.go 51.61% <100%> (ø) ⬆️
integration/testutil.go 75.28% <100%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe436a...eff942c. Read the comment docs.

codecov-io commented Jan 4, 2018

Codecov Report

Merging #900 into master will increase coverage by 0.08%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   52.79%   52.87%   +0.08%     
==========================================
  Files          34       34              
  Lines        2288     2292       +4     
==========================================
+ Hits         1208     1212       +4     
  Misses        874      874              
  Partials      206      206
Impacted Files Coverage Δ
core/keyserver/keyserver.go 0% <0%> (ø) ⬆️
core/keyserver/epochs.go 39.58% <100%> (ø) ⬆️
impl/sql/mutationstorage/mutations.go 64.38% <100%> (ø) ⬆️
impl/sql/domain/storage.go 69.47% <100%> (ø) ⬆️
impl/sql/mutationstorage/queue.go 78.12% <100%> (ø) ⬆️
core/adminserver/admin_server.go 51.61% <100%> (ø) ⬆️
integration/testutil.go 75.28% <100%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe436a...eff942c. Read the comment docs.

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Jan 8, 2018

Collaborator

This PR has been rebased and is ready for a second (much cleaner) look

Collaborator

gdbelvin commented Jan 8, 2018

This PR has been rebased and is ready for a second (much cleaner) look

@phad

phad approved these changes Jan 8, 2018

@gdbelvin gdbelvin merged commit 9a8769b into google:master Jan 8, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:f/queue_1.1 branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment