New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch StartSequencingAll in a separate goroutine #904

Merged
merged 2 commits into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Jan 8, 2018

StartSequencingAll was changed from a non-blocking function, to a blocking function that could return an error, per Go style. This change should have been included in #862

Fixes #868

@gdbelvin gdbelvin requested a review from phad Jan 8, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 8, 2018

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files          34       34           
  Lines        2292     2292           
=======================================
  Hits         1212     1212           
  Misses        874      874           
  Partials      206      206

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8769b...63afb01. Read the comment docs.

codecov-io commented Jan 8, 2018

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files          34       34           
  Lines        2292     2292           
=======================================
  Hits         1212     1212           
  Misses        874      874           
  Partials      206      206

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8769b...63afb01. Read the comment docs.

@phad

phad approved these changes Jan 8, 2018

@gdbelvin gdbelvin merged commit ede30a9 into google:master Jan 8, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment