Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout tests on macos #384

Merged
merged 1 commit into from Jul 15, 2021
Merged

Fix layout tests on macos #384

merged 1 commit into from Jul 15, 2021

Conversation

imjasonh
Copy link
Member

Fixes #256

The default temp dir on macos is something like /var/folders/bb/l0yfqc6d6kb5zm5f9ktyx0nw0000gn/T/ko299660247, which results in error messages like:

    layout_test.go:45: Publish() = repository can only contain the runes `abcdefghijklmnopqrstuvwxyz0123456789_-./`: /var/folders/bb/l0yfqc6d6kb5zm5f9ktyx0nw0000gn/T/ko299660247

By forcing the temp dir into /tmp, we make sure we generate a valid repository.

@imjasonh imjasonh merged commit 56282bf into ko-build:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout test does not seem to work on mac?
2 participants