From 4cb46567d944d5319373211397062b1a08ab5b77 Mon Sep 17 00:00:00 2001 From: Ting-Yuan Huang Date: Wed, 28 Feb 2024 12:59:05 -0800 Subject: [PATCH] Revert "UPDATE_KOTLIN_VERSION: 2.0.0-dev-4562" This reverts commit 6fb3ea5a9fdbfebf956164c2f6cc31592d657df6. (cherry picked from commit b1fefb3a16c87e7a7c61f8f86c5e200dc5dbbb03) --- .../ksp/symbol/impl/binary/KSDeclarationDescriptorImpl.kt | 4 ++-- .../com/google/devtools/ksp/test/KSPCmdLineOptionsIT.kt | 1 - .../kotlin/com/google/devtools/ksp/test/PlaygroundIT.kt | 6 ++++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSDeclarationDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSDeclarationDescriptorImpl.kt index a6ea9b9526..9d9c14f4ca 100644 --- a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSDeclarationDescriptorImpl.kt +++ b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSDeclarationDescriptorImpl.kt @@ -20,10 +20,10 @@ package com.google.devtools.ksp.symbol.impl.binary import com.google.devtools.ksp.common.impl.KSNameImpl import com.google.devtools.ksp.common.memoized import com.google.devtools.ksp.symbol.* +import org.jetbrains.kotlin.backend.common.serialization.findPackage import org.jetbrains.kotlin.descriptors.ClassDescriptor import org.jetbrains.kotlin.descriptors.DeclarationDescriptor import org.jetbrains.kotlin.descriptors.FunctionDescriptor -import org.jetbrains.kotlin.descriptors.findPackage import org.jetbrains.kotlin.load.java.descriptors.JavaClassDescriptor import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe import org.jetbrains.kotlin.resolve.descriptorUtil.parents @@ -50,7 +50,7 @@ abstract class KSDeclarationDescriptorImpl(private val descriptor: DeclarationDe is ClassDescriptor -> KSClassDeclarationDescriptorImpl.getCached(containingDescriptor) is FunctionDescriptor -> KSFunctionDeclarationDescriptorImpl.getCached(containingDescriptor) else -> null - } + } as KSDeclaration? } override val parent: KSNode? by lazy { diff --git a/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/KSPCmdLineOptionsIT.kt b/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/KSPCmdLineOptionsIT.kt index bb6dcc6804..e06136a849 100644 --- a/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/KSPCmdLineOptionsIT.kt +++ b/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/KSPCmdLineOptionsIT.kt @@ -38,7 +38,6 @@ class KSPCmdLineOptionsIT(val useKSP2: Boolean) { }.maxByOrNull { it.lastModified() }!! val compilerArgs = mutableListOf( "-no-stdlib", - "-language-version", "1.9", "-Xplugin=${kspPluginJar.absolutePath}", "-Xplugin=${kspApiJar.absolutePath}", "-P", "plugin:$kspPluginId:apclasspath=${processorJar.absolutePath}", diff --git a/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/PlaygroundIT.kt b/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/PlaygroundIT.kt index a3442aa9b8..ec541ea8d5 100644 --- a/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/PlaygroundIT.kt +++ b/integration-tests/src/test/kotlin/com/google/devtools/ksp/test/PlaygroundIT.kt @@ -223,6 +223,7 @@ class PlaygroundIT(val useKSP2: Boolean) { Assert.assertTrue(jarFile.getEntry("hello/HELLO.class").size > 0) Assert.assertTrue(jarFile.getEntry("com/example/AClassBuilder.class").size > 0) } + Assert.assertTrue(result.output.contains("w: Language version 2.0 is experimental")) project.restore(buildFile.path) } @@ -262,6 +263,7 @@ class PlaygroundIT(val useKSP2: Boolean) { Assert.assertTrue(jarFile.getEntry("hello/HELLO.class").size > 0) Assert.assertTrue(jarFile.getEntry("com/example/AClassBuilder.class").size > 0) } + Assert.assertTrue(result.output.contains("w: Language version 2.0 is experimental")) project.restore(buildFile.path) project.restore(gradleProperties.path) } @@ -302,12 +304,12 @@ class PlaygroundIT(val useKSP2: Boolean) { gradleRunner.withArguments("build").buildAndFail().let { Assert.assertEquals(TaskOutcome.SUCCESS, it.task(":workload:kspKotlin")?.outcome) Assert.assertEquals(TaskOutcome.FAILED, it.task(":workload:compileKotlin")?.outcome) - Assert.assertTrue("Unresolved reference 'AClassBuilder'" in it.output) + Assert.assertTrue("Unresolved reference: AClassBuilder" in it.output) } gradleRunner.withArguments("build").buildAndFail().let { Assert.assertEquals(TaskOutcome.UP_TO_DATE, it.task(":workload:kspKotlin")?.outcome) Assert.assertEquals(TaskOutcome.FAILED, it.task(":workload:compileKotlin")?.outcome) - Assert.assertTrue("Unresolved reference 'AClassBuilder'" in it.output) + Assert.assertTrue("Unresolved reference: AClassBuilder" in it.output) } project.restore("workload/build.gradle.kts")