Exceptions are swallowed when using withCompilation flag

[idanakav]

Hey, per title, when returnOkOnError=false && withCompilation=true I would expect to fail with calling
AnalysisResult.compilationError instead of proceeding with the compilation.

Any reason we would not want to fail fast in that scenario?

Happy to submit a PR in case you agree with this case.

[neetopia]

They are not really swallowed, it is intentional. The reason is that we want to provide most details about errors in the code, KSP is not able to provide any diagnostics due to its limitation, therefore when withCompilation flag is enabled, we want the users still have a chance to get the diagnostics from the compiler for troubleshooting.

[Gzernov]

I agree with @idanakav. When I have withCompilation enabled, I would still like my build to fail if there is an error.
@neetopia 's argument also sounds reasonable. While it may not be a good solution in general, one more flag can be added that forces build to fail on error (even if that means that user is no longer have access to the proper diagnostics)
Thoughts?

[neetopia]

Fair enough, let me consider it. Will keep you updated.

[idanakav]

@neetopia wondering if you had a chance to give it any thoughts? do you think an extra flag would be the way to go? I'm happy to help with contributing.

[neetopia]

Thanks for the remind, added to next milestone for discussion.

[neetopia]

This actually looks like a bug to me after taking a deep look, basically the logic here ignores returnOkOnError when withCompilation is set to true. Current plan is to fix it rather than introducing a new flag.