Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Version::ForEachOverlapping to implement Version::Get() #698

Merged
merged 7 commits into from Aug 28, 2019

Conversation

@neal-zhu
Copy link
Contributor

neal-zhu commented Jun 11, 2019

This code has been tested with existing tests and no new tests are written because it justs implements Version:: Get() with Version:: ForEachOverlapping() which has been fully tested.

neal-zhu added 4 commits Jun 11, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Jun 11, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jun 11, 2019
@neal-zhu

This comment has been minimized.

Copy link
Contributor Author

neal-zhu commented Jun 11, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jun 11, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 11, 2019
db/version_set.cc Outdated Show resolved Hide resolved
db/version_set.cc Outdated Show resolved Hide resolved
db/version_set.cc Show resolved Hide resolved
db/version_set.cc Outdated Show resolved Hide resolved
db/version_set.cc Outdated Show resolved Hide resolved
@cmumford cmumford force-pushed the google:master branch from 2b0ce28 to 9ee91ac Jun 13, 2019
Copy link
Contributor

ghemawat left a comment

Thanks for making the changes. Just a couple of small things left.

db/version_set.cc Outdated Show resolved Hide resolved
db/version_set.cc Outdated Show resolved Hide resolved
@googlebot

This comment has been minimized.

Copy link

googlebot commented Aug 28, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 28, 2019
@neal-zhu

This comment has been minimized.

Copy link
Contributor Author

neal-zhu commented Aug 28, 2019

@googlebot I fixed it.

@neal-zhu neal-zhu force-pushed the neal-zhu:master branch from 7435213 to 107a75b Aug 28, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Aug 28, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 28, 2019
@neal-zhu

This comment has been minimized.

Copy link
Contributor Author

neal-zhu commented Aug 28, 2019

@ghemawat sorry for delaying for so long!

@pwnall

This comment has been minimized.

Copy link
Member

pwnall commented Aug 28, 2019

@ghemawat LGTMed this PR. It's now going through our internal repository, and will be merged in the near future. Thank you very much for your contribution!

pwnall added a commit that referenced this pull request Aug 28, 2019
PiperOrigin-RevId: 266001777
@pwnall pwnall merged commit 5e92189 into google:master Aug 28, 2019
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
import/copybara Change imported to the internal review system
Details
@neal-zhu

This comment has been minimized.

Copy link
Contributor Author

neal-zhu commented Aug 29, 2019

THANKS !!!!! This means a lot to me!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.