Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager #818

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Swift Package Manager #818

wants to merge 3 commits into from

Conversation

paulb777
Copy link
Member

@pwnall
Copy link
Member

pwnall commented Jul 13, 2020

Thank you for your contribution!

I don't want this repository to grow build configurations for all major languages and package managers. So, unfortunately, I must say no to all such contributions.

I really appreciate the addition of CI coverage for the correctness of your packaging! Please consider hosting your own repository for the swift packaging! You can pull in leveldb as a git submodule.

@pwnall pwnall closed this Jul 13, 2020
@paulb777
Copy link
Member Author

Thanks for the response. According to https://forums.swift.org/t/package-with-git-submodule-doesnt-build-correctly/27852, Swift Package Manager does not support git submodules so it looks like we'll go with a leveldb fork for Firebase and perhaps consolidate the CocoaPods leveldb support there as well.

@pwnall
Copy link
Member

pwnall commented Jul 13, 2020

Oh I didn't realize this is for Firebase.

@MoNTE48
Copy link

MoNTE48 commented May 27, 2021

@pwnall, will this someday be merged? It's just 1 swift file and it's pretty darn simple.

@paulb777
Copy link
Member Author

paulb777 commented Jun 1, 2021

@MoNTE48 In the meantime, Firebase is managing a leveldb fork with SPM support. See https://github.com/firebase/leveldb/tree/spm and https://github.com/firebase/firebase-ios-sdk/blob/master/Package.swift#L179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants