-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager #818
base: main
Are you sure you want to change the base?
Conversation
paulb777
commented
Jul 10, 2020
- Adds build support for Swift Package Manager
- Adds a GitHub Action to verify the build
- Tested in conjunction with SPM: Build and unit test RTDB firebase/firebase-ios-sdk#6022
|
Thank you for your contribution! I don't want this repository to grow build configurations for all major languages and package managers. So, unfortunately, I must say no to all such contributions. I really appreciate the addition of CI coverage for the correctness of your packaging! Please consider hosting your own repository for the swift packaging! You can pull in leveldb as a git submodule. |
|
Thanks for the response. According to https://forums.swift.org/t/package-with-git-submodule-doesnt-build-correctly/27852, Swift Package Manager does not support |
|
Oh I didn't realize this is for Firebase. |
|
@pwnall, will this someday be merged? It's just 1 swift file and it's pretty darn simple. |
|
@MoNTE48 In the meantime, Firebase is managing a leveldb fork with SPM support. See https://github.com/firebase/leveldb/tree/spm and https://github.com/firebase/firebase-ios-sdk/blob/master/Package.swift#L179 |