New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for privileged and unprivileged connections #4

Merged
merged 2 commits into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@alessandrogario
Contributor

alessandrogario commented Jul 2, 2018

This PR adds support for separating the interface into privileged and unprivileged, depending on the permissions of the connecting client

@alessandrogario

This comment has been minimized.

Show comment
Hide comment
@alessandrogario

alessandrogario Jul 2, 2018

Contributor

Hello @russellhancox!

Thanks for reviewing the PR! It's a lot better now with your corrections 👍

I also updated the tests by adding a dummy protocol because we are now failing the connection if there is no interface set.

Contributor

alessandrogario commented Jul 2, 2018

Hello @russellhancox!

Thanks for reviewing the PR! It's a lot better now with your corrections 👍

I also updated the tests by adding a dummy protocol because we are now failing the connection if there is no interface set.

@russellhancox

Thanks again!

@russellhancox russellhancox merged commit 4790f8c into google:master Jul 2, 2018

1 check passed

cla/google All necessary CLAs are signed
@russellhancox

This comment has been minimized.

Show comment
Hide comment
@russellhancox

russellhancox Jul 2, 2018

Contributor

This has been published in v1.2 and pushed to CocoaPods. A 'pod update' in dependent projects will pick this up.

Contributor

russellhancox commented Jul 2, 2018

This has been published in v1.2 and pushed to CocoaPods. A 'pod update' in dependent projects will pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment