Skip to content
Permalink
Browse files

Modify Mako example to not use invalid metric value key (containing a…

…n underscore). A validation error is returned when attempting to update the benchmark with a metric value key containing an underscore.

PiperOrigin-RevId: 282817907
Change-Id: I2e460935933a8924f9de5b5ee195cc583354cbec
  • Loading branch information
timford committed Nov 27, 2019
1 parent 2db724d commit 64b392ef36eac072cc3b20095e757feaa21f7ecd
Showing with 1 addition and 1 deletion.
  1. +1 −1 examples/go_quickstore/example_test.go
@@ -98,7 +98,7 @@ func TestPerformance(t *testing.T) {
// Add a Rolling Window Reducer config to calculate the QPS of the wl metric
// Read more about the Rolling Window Reducer at https://github.com/google/mako/blob/master/proto/helpers/rolling_window_reducer/rolling_window_reducer.proto
InputMetricKeys: []string{"wl"},
OutputMetricKey: proto.String("wl_qps"),
OutputMetricKey: proto.String("wqps"),
WindowOperation: rpb.RWRConfig_COUNT.Enum(),
WindowSize: proto.Float64(1000),
StepsPerWindow: proto.Int32(1),

0 comments on commit 64b392e

Please sign in to comment.
You can’t perform that action at this time.