Test branch for agentspace deployment #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add env-setup target to Makefile for creating .env from .env.example - Update .env.example with optimized model and timeout settings - Enhance env_manager.py with better validation for UUIDs and URLs - Fix server name reference from 'soar' to 'secops_soar' in env_manager
- Update .gitignore to exclude markdown library files - Improve adk-deploy target in Makefile with better lib handling and bucket generation - Fix agent.py initialization to avoid global variable issues - Streamline env_manager.py by removing unnecessary agent_engine requirements - Add automatic cleanup of copied libs after deployment
This commit fixes multiple deployment issues that prevented MCP tools from loading properly: **Cloud Run Deployment:** - Fixed cloudrun_deploy.py to point to correct agents directory structure - Added Python path configuration for libs imports - Updated cloudrun_deploy_run.sh to handle correct file paths and cleanup - Fixed Makefile to read environment variables from .env file for deployment **ADK Local Testing:** - Updated run-adk-agent.sh to specify agents directory for adk web - Added automatic libs copying for local testing - Fixed Python path in agent.py to find local libs directory **MCP Server Loading:** - Fixed environment variable mapping for all MCP servers (secops, gti, soar, scc) - Added proper server entry point handling (scc uses scc_mcp.py, others use server.py) - Added comprehensive logging for debugging MCP server initialization - Fixed BASE_DIR and SERVER_DIR path detection for both local and Cloud Run environments **Agent Configuration:** - Added default values for GOOGLE_MODEL and DEFAULT_PROMPT to prevent validation errors - Improved .env file path detection for different deployment environments - Added flexible path handling for both local development and container deployment **Makefile Improvements:** - Fixed cloudrun-logs target to properly read project/region from .env - Updated adk-deploy target to read environment variables correctly - Removed dangerous server directory cleanup that could delete original files All MCP tools (SCC, SecOps, GTI, SOAR) now load correctly in both local and Cloud Run deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan