-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit default styles for markdown #305
Comments
Rename the CSS classname from "markdown" to something more specific like "error-box-markdown", otherwise it becomes confusing what this is for. Context: 28c43da |
In general the css style currently used for mesop from my reading is more like a "reset css" to be used as a base to apply style on top of. (https://necolas.github.io/normalize.css/) The formatting of this in general seems odd, especially with respect to margins around various text styles, and the zero-margin around the page in general. |
@itsayellow agree the default styles aren't super easy to work with. Are there specific changes to the default styles that you'd like to see? The zero-margin around the page is intended to give the app developer greater flexibility, but this requires the app developer to often do some boilerplate to create a container with reasonable margins on the side, e.g. Lines 70 to 71 in ad19d57
I think we could provide some examples in our demo gallery on setting up this container, but I don't think we will automatically add in margins/padding by default |
In my mind I would think that this default style could remain the default, but there would be an alternate style(s) somehow available in the API or built-in files that would allow it to look good in a web browser out of the box. For me, a lot of the header styles have strange spacings around them--the headers have no space above and a huge amount of space below their lines. Additionally the zero-margin around the edges means that it needs extra work to look good as its own page, and not as a frame inside a bigger web page. Lastly, just some general "prettiness" amongst the various styles would be nice, but this is the last priority. Basically I use this kind of library because I know how to write Python and want to avoid making my own CSS or web design in general as much as humanly possible. 😄 |
In particular:
The
margin: 0
makes the markdown hard to read.The text was updated successfully, but these errors were encountered: