New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP state doesn't resync correctly when adding a BGP session via node labels #181

Closed
danderson opened this Issue Mar 4, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@danderson
Copy link
Member

danderson commented Mar 4, 2018

Is this a bug report or a feature request?:

Bug, thanks to @jpiper for reporting on slack.

What happened:

If you cause a BGP session to be added to a node by editing node labels, the session comes up, but the existing advertised IPs don't get propagated on that BGP session.

How to reproduce it (as minimally and precisely as possible):

Add a BGP peer to MetalLB's config, with a node selector.
Make the selector match some nodes, so that BGP sessions establish.
Set up a service, verify that speaker is advertising it.
Edit node labels so selector no longer matches. Verify speaker tore down the BGP session.
Edit node labels so selector applies again. Verify speaker sets up BGP session, but does not readvertise IPs.

Environment:

  • MetalLB version: 0.4.1

@danderson danderson added the bug label Mar 4, 2018

@danderson danderson self-assigned this Mar 4, 2018

@danderson

This comment has been minimized.

Copy link
Member

danderson commented Mar 4, 2018

Fixed by 025ada8.

@danderson danderson closed this Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment