New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDP speaker needs to refcount solicited node multicast group memberships #184

Closed
danderson opened this Issue Mar 5, 2018 · 1 comment

Comments

2 participants
@danderson
Copy link
Member

danderson commented Mar 5, 2018

Currently, the NDP speaker implementation leaves the solicited node multicast group for an IP whenever the balancer is deleted. However, solicited node multicast groups are shared by many addresses, and we need to remain in the group as long as we own at least one IP mapped into that group.

The NDP speaker's multicast group logic needs to refcount the uses of each solicited node multicast group, and only leave when the refcount hits zero.

@danderson danderson added the bug label Mar 5, 2018

@danderson danderson added this to the v0.5.0 milestone Mar 5, 2018

@danderson danderson self-assigned this Mar 5, 2018

@danderson danderson added this to To Do in IPv6 support via automation Mar 5, 2018

@mdlayher

This comment has been minimized.

Copy link
Collaborator

mdlayher commented Mar 5, 2018

Makes sense, although I imagine it would be pretty unlikely for two addresses to share the same group.

danderson added a commit to danderson/metallb that referenced this issue Mar 18, 2018

@danderson danderson closed this in 36ef701 Mar 18, 2018

IPv6 support automation moved this from To Do to Done Mar 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment