Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
metallb does not deallocate a Service's IP on Service type change to non-LB #190
Is this a bug report or a feature request?:
Changing the type of a Service with a metallb-assigned IP from
What you expected to happen:
I expected the IP address to be returned to the pool; reachability of the Service to be lost; and the
How to reproduce it (as minimally and precisely as possible):
metal v0.4.3 running a K8S 1.8.6 cluster. Create a NodePort service. Edit the
After that has been successful, edit the Service and change
Anything else we need to know?:
Thanks for the report!
I see where the bug is in the code, I'll cut 0.4.4 with a fix shortly.
I'm surprised this can happen, because when I was developing MetalLB on k8s 1.8, I think I was unable to change the type of a Service after creation... So the codepath just assumes that if something is not a LoadBalancer, then it never was a LoadBalancer and we don't need to run the deletion logic. Oops!