Skip to content
Permalink
Branch: master
Commits on Feb 26, 2018
  1. Pull google/googletest@8a61587

    yukawa committed Feb 26, 2018
    This CL updates src/third_party/gtest as follows:
      from: google/googletest@82b11b8
        to: google/googletest@8a61587
    
    BUG=
    TEST=unittest
  2. Support import from MS-IME user dictionary

    yukawa committed Feb 26, 2018
    With this CL, mozc_tool can import user dictionary from MS-IME when
    running on Windows.
    
    One tricky point is that NTDDI_VERSION needs to be NTDDI_WIN8 or
    higher to use MSIME APIs/constants defined in <msime.h>.  I believe
    this is a bug in <msime.h>, but it seems that the only available
    simple solution for us is to re-define NTDDI_VERSION (and _WIN32_WINNT
    just in case) only while including <msime.h>.
    
    Note that we can safely remove this hack once we stop supporting
    Windows 7 and can bump _WIN32_WINNT to be WIN32_WINNT_WIN8 or higher.
    
    REF_BUG=
    REF_CL=186964780
    REF_TIME=2018-02-26T11:37:53+09:00
    REF_TIME_RAW=1519612673 +0900
Commits on Feb 24, 2018
  1. No need to define WIN32_IE/WINVER/NTDDI_VERSION

    yukawa committed Feb 24, 2018
    Those macros can automatically be calculated in Windows SDK headers
    (actually by SDKDDKVer.h) based on _WIN32_WINNT.  There is no need for
    us to explicitly define those macros.
    
    REF_BUG=
    REF_CL=186904155
    REF_TIME=2018-02-25T08:48:23+09:00
    REF_TIME_RAW=1519516103 +0900
Commits on Jan 1, 2018
  1. Amend a typo in the copyright year

    yukawa committed Jan 1, 2018
    This CL am amends a typo in the copyright year in the file header of
    docker/fedora23/Dockerfile, which was introduced in my previous
    CL [1].
    
     [1]: f5ddd0e
  2. Update the copyright year to 2018

    yukawa committed Jan 1, 2018
    REF_BUG=
    REF_CL=180466480
    REF_TIME=2018-01-01T00:00:18-08:00
    REF_TIME_RAW=1514793618 -0800
Commits on Dec 31, 2017
  1. Do not use mozc_renderer on wayland session

    yukawa committed Dec 31, 2017
    Closes #431.
    
    BUG=#431
    TEST=manually verified on Fedora 27
    REF_BUG=
    REF_CL=180437575,180453136
    REF_TIME=2017-12-31T07:26:08-08:00
    REF_TIME_RAW=1514733968 -0800
  2. Migrate from IBusConfig to GSetting in ibus_mozc

    yukawa committed Dec 31, 2017
    With this CL, ibus_mozc directly uses GSettings API instead of
    IBusConfig to read IBus font settings specified with 'ibus-setup'
    command.
    
    Basically there should be no user visible behavior change in this API
    migration.
    
    Closes #429.
    
    BUG=#429
    TEST=Tested manually as follows
         1. Build and install Mozc to Ubuntu 14.04.
         2. Make sure that mozc_renderer is working.
         3. Run `ibus-setup` to set a custom font for the candidate
            window.
         4. Make sure that mozc_renderer starts using the custom font
            specified at the step 3.
    REF_BUG=
    REF_CL=180437307,180454744
    REF_TIME=2017-12-31T07:15:11-08:00
    REF_TIME_RAW=1514733311 -0800
  3. Support GYP_DEFINES='enable_gtk_renderer=0'

    yukawa committed Dec 31, 2017
    Currently there is no easy way to disable gtk_renderer at compile time
    because build_mozc.py always sets 'enable_gtk_renderer=1' if the
    target platform is Linux.
    
    With this CL, packagers can explicitly disable mozc_renderer as
    follows.
    
      GYP_DEFINES='enable_gtk_renderer=0' python build_mozc.py gyp
    
    REF_BUG=
    REF_CL=180436823,180453130
    REF_TIME=2017-12-31T07:01:23-08:00
    REF_TIME_RAW=1514732483 -0800
  4. Pull protocolbuffers/protobuf@92a7e77

    yukawa committed Dec 31, 2017
    This CL updates src/third_party/protobuf as follows:
      from: protocolbuffers/protobuf@c44ca26
        to: protocolbuffers/protobuf@92a7e77
    
    BUG=
    TEST=runtests
  5. Update Android NDK from r12b to r16b

    yukawa committed Dec 31, 2017
    This CL also drops MIPS/MIPS64 build configurations from Travis CI,
    since NDK r16 deprecated those build targets [1].
    
     [1]: https://github.com/android-ndk/ndk/wiki/Changelog-r16
    
    BUG=
    TEST=compile
  6. Switch to ninja 1.7.2 on AppVeyor

    yukawa committed Dec 31, 2017
    With this CL, ninja used to build Mozc for Windows in AppVeyor is
    switched from 1.7.1 to 1.7.2.
    
    This CL also addresses the following warning message.
    
      Parsing -version resulted in error (converted to warning):
       Cannot bundle unregistered option '-e'.
Commits on Dec 30, 2017
  1. Add a custom entry point for 'protoc'

    yukawa committed Dec 30, 2017
    This CL introduces our own entry point for 'protoc' since we use
    'protoc' to generate bindings only for C++ and Java languages.  Adding
    our own entry point allows us to reduce the number of *.cc files that
    need to be built for 'protoc', which is a huge win for us in terms of
    build speed and maintainability.
    
    REF_BUG=68382821
    REF_CL=180377327,180415001
    REF_TIME=2017-12-29T23:44:39-08:00
    REF_TIME_RAW=1514619879 -0800
  2. Fix a missing hard dependency in minimal_engine

    yukawa committed Dec 30, 2017
    'minimal_engine.h' indirectly depends on "protocol/config.pb.h" via
    'composer/composer.h'.
    
    Unfortunately just adding a dependency on
    'composer/composer.gyp:composer' isn't sufficient for GYP to
    understand this dependency.  We have to teach GYP that 'config.pb.h'
    needs to be generated before building 'minimal_engine.cc' by adding an
    explicit dependency on 'protocol.gyp:config_proto' from
    'minimal_engine'.
    
    Otherwise, Android build may fail depending on the parallel build
    execution plan and CPU resources in the build environment.  You can
    actually trigger this situation as follows.
    
     1. python build_mozc.py gyp
     2. python build_mozc.py build engine/engine.gyp:minimal_engine
    
    This issue has existed since 181fcd2.
    
    TEST=python build_mozc.py gyp && python build_mozc.py build engine/engine.gyp:minimal_engine
    REF_BUG=
    REF_CL=180375916
    REF_TIME=2017-12-29T22:54:25-08:00
    REF_TIME_RAW=1514616865 -0800
Commits on Dec 29, 2017
  1. Minor document updates

    yukawa committed Dec 29, 2017
  2. Switch to xcode9.2 on Travis macOS build

    yukawa committed Dec 29, 2017
    This should fix build failures on Travis macOS build due to the lack
    of 10.13 SDK, which was recently required [1].
    
     [1]: ea9d0bd
  3. Fix warning: not handled in switch [-Wswitch]

    yukawa committed Dec 29, 2017
    When Mozc is built with Qt 5.5 or higher, you may see the following
    warning as there is no handler for 'QtInfoMsg' message type.
    
      ../../gui/base/debug_util.cc:44:11: warning: enumeration value 'QtInfoMsg' not handled in switch [-Wswitch]
        switch (type) {
              ^
      1 warning generated.
    
    This CL fixes the above warning by explicitly adding 'QtInfoMsg'
    handler if the Qt version is 5.5 or higher.
    
    Perhaps we may consider adding "default" case there so that we don't
    see this warning again, but I decided not to do that (at least in this
    CL) as this warning was actually useful (at least for me).
    
    REF_BUG=
    REF_CL=180312466
    REF_TIME=2017-12-28T19:50:48-08:00
    REF_TIME_RAW=1514519448 -0800
Commits on Dec 28, 2017
  1. Directly download android-support-v13.jar v23.1.1

    yukawa committed Dec 28, 2017
    This closes #406, closes #410, closes #417, closes #414,
    and closes #418.
    
    BUG=#406,#410,#417,#418
    TEST=complied inside Docker
  2. Add missing progurad rules for Android build

    yukawa committed Dec 28, 2017
    Proguard rules for the following were missed, which has caused runtime
    crash only on release builds.
    
     * MozcJNI#getDataVersion() [1]
     * MozcJNI#suppressSendingStats(boolean) [2]
    
    This CL teaches Proguard to keep those native methods.
    
    Closes #420.
    
     [1]: 00fb3fb
     [2]: 6c1b1cc
    
    BUG=#420
    TEST=dexdump MozcForAndroid-release-unsigned.apk | grep getDataVersion
    TEST=dexdump MozcForAndroid-release-unsigned.apk | grep suppressSendingStats
    REF_BUG=
    REF_CL=180250226
    REF_TIME=2017-12-28T00:57:19-08:00
    REF_TIME_RAW=1514451439 -0800
Commits on Dec 13, 2016
  1. Release History: 2.19.2644.102 to 2.20.2673.102

    yukawa committed Dec 13, 2016
    This CL summarizes changes made in the following release range.
      from: 2.19.2644.102 (c19cc87)
        to: 2.20.2673.102 (280e38f)
  2. Release History: 2.18.2613.102 to 2.19.2643.102

    yukawa committed Dec 13, 2016
    This CL summarizes changes made in the following release range.
      from: 2.18.2613.102 (f76c304)
        to: 2.19.2643.102 (f5dcadf)
  3. Pull protocolbuffers/protobuf@c44ca26 again (try 2)

    yukawa committed Dec 13, 2016
    The previous commit 6ce633c
    unintentionally switched the protobuf revision to
    eb455ce1c92e9fc217ece0cfc58f9a698fd0f635.
    
    With this CL, src/third_party/protobuf will be downgraded as follows
    to fix build breakage on NaCl.
      from: protocolbuffers/protobuf@eb455ce
        to: protocolbuffers/protobuf@c44ca26
    
    BUG=
    TEST=git submodule update --init && compile
    REF_BUG=
    REF_CL=
    REF_TIME=2016-12-20T20:23:59-08:00
    REF_TIME_RAW=1481603039 -0800
  4. Pull protocolbuffers/protobuf@c44ca26 again

    yukawa committed Dec 13, 2016
    This CL downgrades src/third_party/protobuf as follows to fix build
    breakage on NaCl.
      from: protocolbuffers/protobuf@39f9b43
        to: protocolbuffers/protobuf@c44ca26
    
    BUG=
    TEST=compile
    REF_BUG=
    REF_CL=
    REF_TIME=2016-12-12T20:06:44-08:00
    REF_TIME_RAW=1481602004 -0800
Commits on Dec 9, 2016
  1. Pull protocolbuffers/protobuf@39f9b43

    yukawa committed Dec 9, 2016
    This CL updates src/third_party/protobuf as follows:
      from: protocolbuffers/protobuf@c44ca26
        to: protocolbuffers/protobuf@39f9b43
    
    BUG=
    TEST=
    REF_BUG=
    REF_CL=141504600
    REF_TIME=2016-12-08T17:19:39-08:00
    REF_TIME_RAW=1481246379 -0800
Commits on Dec 5, 2016
  1. Use UTF-8 string literals under src/win32/

    yukawa committed Dec 5, 2016
    BUG=#385
    TEST=
    REF_BUG=31204285
    REF_CL=141003342
    REF_TIME=2016-12-04T17:38:52-08:00
    REF_TIME_RAW=1480901932 -0800
  2. Use UTF-8 string literals under unix/ibus/ part 2

    yukawa committed Dec 5, 2016
    This is a follow up CL to 1ab158d.
    
    BUG=#385
    TEST=
    REF_BUG=31204285
    REF_CL=141003337
    REF_TIME=2016-12-04T17:38:27-08:00
    REF_TIME_RAW=1480901907 -0800
  3. Honor 'mac_sdk' GYP variable in build_breakpad.py

    yukawa committed Dec 5, 2016
    This is a follow up CL to c19cc87.
    
    With this CL, the target SDK used in build_breakpad.py will be
    automatically set based on 'mac_sdk' GYP variable rather then the
    version hard-coded in build_breakpad.py.
    
    BUG=
    TEST=
    REF_BUG=31891161
    REF_CL=141003326
    REF_TIME=2016-12-04T17:38:07-08:00
    REF_TIME_RAW=1480901887 -0800
Commits on Dec 1, 2016
  1. Set Qt::WindowCloseButtonHint

    yukawa committed Dec 1, 2016
    The lack of Qt::WindowCloseButtonHint had not been obvious until we
    switched to Qt 5, where the close icon on the dialog frame does not work
    because of that.
    
    Fix #400.
    
    BUG=#400
    TEST=Manually on Qt 4.8.7 (Win), Qt 5.6.2 (Win), Qt 5.2.1 (Ubuntu 14.04)
    REF_BUG=33255809
    REF_CL=140697910
    REF_TIME=2016-11-30T23:53:06-08:00
    REF_TIME_RAW=1480578786 -0800
  2. Specify the correct the parent to KeyBindingEditor

    yukawa committed Dec 1, 2016
    Seems that we have specified a wrong parent to KeyBindingEditor, which
    had not been obvious until we switched to Qt 5, where OK/Cancel buttons
    do not work because of this.
    
    Fix #399.
    
    BUG=#399
    TEST=Manually on Qt 4.8.7 (Win), Qt 5.6.2 (Win), Qt 5.2.1 (Ubuntu 14.04)
    REF_BUG=33256462
    REF_CL=140696390
    REF_TIME=2016-11-30T23:15:33-08:00
    REF_TIME_RAW=1480576533 -0800
Commits on Nov 23, 2016
  1. Fully qualify std:: part 7

    yukawa committed Nov 23, 2016
    BUG=#392
    TEST=compile
    REF_BUG=
    REF_CL=140073760,140141915,140867036,141003367,141434054,141562582,141612029,141626248,141637161
    REF_TIME=2016-11-23T14:44:47-08:00
    REF_TIME_RAW=1479941087 -0800
Commits on Nov 14, 2016
  1. Use macOS 11.0 SDK by default

    yukawa committed Nov 14, 2016
    With this CL Mozc starts using macOS 11.0 SDK by default.
    
    This CL also updates build environment on Travis CI as follows.
     - Xcode: 6.4 -> 7.3.1
     - macOS: 10.10 -> 10.11
    
    BUG=
    TEST=compile
    REF_BUG=30725799
    REF_CL=
    REF_TIME=2016-11-13T18:00:26-08:00
    REF_TIME_RAW=1479088826 -0800
Commits on Nov 7, 2016
  1. Built GUI tools for macOS on Travis CI

    yukawa committed Nov 7, 2016
    With this CL, continuous build on Travis CI makes sure that GUI tools
    can be built with Qt5 on mac.
    
    BUG=#327
    TEST=compile
    REF_BUG=
    REF_CL=
    REF_TIME=2016-11-06T22:39:01-08:00
    REF_TIME_RAW=1478500741 -0800
  2. Merge remaining diffs into OSS repository

    yukawa committed Nov 7, 2016
    BUG=
    TEST=
    REF_BUG=
    REF_CL=99338107,138347841
    REF_TIME=2016-11-06T19:14:36-08:00
    REF_TIME_RAW=1478488476 -0800
  3. Add more translations for Android

    yukawa committed Nov 7, 2016
    BUG=
    TEST=
    REF_BUG=
    REF_CL=138347699
    REF_TIME=2016-11-06T19:11:10-08:00
    REF_TIME_RAW=1478488270 -0800
Commits on Oct 25, 2016
  1. Fix missing D2DERR_RECREATE_TARGET handling

    yukawa committed Oct 25, 2016
    The root cause of #348 is the lack of D2DERR_RECREATE_TARGET handling in
    |DirectWriteTextRenderer::dc_render_target_|.  We can easily reproduce
    this issue by manually disabling a display adaptor on the device
    manager.
    
    Note that we actually have had D2DERR_RECREATE_TARGET handling for
    |dc_render_target_->EndDraw()|, which, however, has never worked because
    any failure of |dc_render_target_->BindDC(dc, &total_rect)| can cause
    early exit.
    
    With this CL, we can more reliably recover from D2DERR_RECREATE_TARGET
    state.
    
    BUG=#348
    TEST=manually done
    REF_BUG=23803925
    REF_CL=137123575
    REF_TIME=2016-10-24T23:53:42-07:00
    REF_TIME_RAW=1477378422 -0700
  2. Fix up missing file permissions during installation

    yukawa committed Oct 25, 2016
    This CL addresses the missing file permission issue on machines that
    were upgraded from Windows 7 to Windows 8 or later versions.
    
    In order to support sandboxed applications on on Windows 8 and later
    OSes, certain Mozc executables need to allow read/execute access for
    "ALL APPLICATION PACKAGES" group.  This is basically done by default if
    Windows 8 or later OS is fresh-installed because "Program Files" already
    has such an ACL (Access Control Entry) with inheritable bit.
    
    If the machine was upgraded from Windows 7 or prior, however, already
    existing folders such as "Program Files/Google" may not have such an ACE
    even after OS upgrade.  For those machines, Mozc needs to manually fix
    up permissions in the installer.  For now following four files need to
    be accessible from sandboxed applications.
     - GoogleIMEJaTIP32.dll      (mozc_tip32.dll)
     - GoogleIMEJaTIP64.dll      (mozc_tip64.dll)
     - GoogleIMEJaConverter.exe  (mozc_server.exe)
     - GoogleIMEJaRenderer.exe   (mozc_renderer.exe)
    
    To be precise, last two files just need to be visible to first two files
    running in sandboxed applications to make sure IPC servers are valid (by
    using GetNamedPipeServerProcessId API).  Note that Windows does not
    require the parent directly also needs to be readable.  We can basically
    care only about those fore files' permission.
    
    There are basically two ways to fix up in our installer.  One is to
    write such logic by C++ and run as a custom action, and the other is to
    let Windows Installer do by using MsiLockPermissionsEx table.  The later
    idea is actually easier.  We can use MsiLockPermissionsEx as follows.
    
      <Component Id='GIMEJaTIP64' Guid='*' Permanent='no'>
        <File Id='GoogleIMEJaTIP64.dll'
              Name='GoogleIMEJaTIP64.dll'
              DiskId='1' Checksum='yes'
              Source='$(var.MozcTIP64Path)' Vital='yes'>
          <PermissionEx
                  Sddl="O:SYG:SYD:AI(A;;0x1200a9;;;AC)(A;ID;FA;;;SY)(A;ID;FA;;;BA)(A;ID;0x1200a9;;;BU)(A;ID;0x1200a9;;;AC)">
        </File>
      </Component>
    
    However, if we use MsiLockPermissionsEx, Windows Installer always
    overwrites existing file permissions, which could cause some troubles if
    later version of Windows starts adding a new permission to directories
    under "Program Files".  Therefore, this CL uses a custom action as a
    more predictable and reliable way to just fix up a missing permission.
    
    BUG=
    TEST=
    REF_BUG=31902088
    REF_CL=137117790
    REF_TIME=2016-10-24T22:02:44-07:00
    REF_TIME_RAW=1477371764 -0700
Older
You can’t perform that action at this time.