New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial reconversion after turning IBus on doesn't start #107

Closed
GoogleCodeExporter opened this Issue Apr 22, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 22, 2015

What steps will reproduce the problem?
1. Turn IBus on (Ctrl-SPC)
2. Select characters to convert
3. Type keys bound to "Reconversion"

What is the expected output? What do you see instead?

I expected that reconversion starts immediately, but nothing happened. I typed 
the reconversion keys again, then the conversion started.

What version of the product are you using? On what operating system?

Mozc 1.3.911.102
Ubuntu 11.10 amd64
IBus 1.4.0-1ubuntu2
Gedit 3.2.1-0ubuntu2
Leafpad 0.8.17-5

Please provide any additional information below.

It seems that needs_surrounding_text flag is not set until the reconversion 
keys are typed first time, so the clients cannot send the surrounding text to 
Mozc engine before that.

Original issue reported on code.google.com by irieshin...@gmail.com on 30 Nov 2011 at 6:14

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Apr 22, 2015

Description of ibus_engine_get_surrounding_text() says:

It is also used to tell the input-context that the engine will utilize 
surrounding-text. In that case, it must be called in "enable" handler, with 
both text and cursor set to NULL.

So, this function have to be called from MozcEngine::Enable() as follows:

  ibus_engine_get_surrounding_text(engine, NULL, NULL, NULL);

Please check request_surrounding_text.patch I attached.

Original comment by irieshin...@gmail.com on 1 Dec 2011 at 8:28

Attachments:

GoogleCodeExporter commented Apr 22, 2015

Description of ibus_engine_get_surrounding_text() says:

It is also used to tell the input-context that the engine will utilize 
surrounding-text. In that case, it must be called in "enable" handler, with 
both text and cursor set to NULL.

So, this function have to be called from MozcEngine::Enable() as follows:

  ibus_engine_get_surrounding_text(engine, NULL, NULL, NULL);

Please check request_surrounding_text.patch I attached.

Original comment by irieshin...@gmail.com on 1 Dec 2011 at 8:28

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Apr 22, 2015

Hello,

Thank you for your report and follow-up.
But I'm really sorry, we cannot apply (or even read) your patch due to company 
policy.
I accepted this bug and will fix until next release.

Thank you for your corporation.

Original comment by n...@google.com on 1 Dec 2011 at 10:23

  • Changed state: Accepted

GoogleCodeExporter commented Apr 22, 2015

Hello,

Thank you for your report and follow-up.
But I'm really sorry, we cannot apply (or even read) your patch due to company 
policy.
I accepted this bug and will fix until next release.

Thank you for your corporation.

Original comment by n...@google.com on 1 Dec 2011 at 10:23

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Apr 22, 2015

I think you can read my patch because I have already become a contributor of 
Mozc project last year. See src/CONTRIBUTORS file.

Original comment by irieshin...@gmail.com on 1 Dec 2011 at 11:33

GoogleCodeExporter commented Apr 22, 2015

I think you can read my patch because I have already become a contributor of 
Mozc project last year. See src/CONTRIBUTORS file.

Original comment by irieshin...@gmail.com on 1 Dec 2011 at 11:33

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Apr 22, 2015

Hello Irie san,

We are not able to use external codes due to our company policy, even though it 
is from a contributor.  We use the internal code repository as our primary 
repository and we cannot check in any external code into the repository.  I 
admit this is inconvenient and confusing.  I have been figuring out a better 
way, but it would take a longer time to solve it.

Thank you for your patience,


Original comment by koma...@google.com on 2 Dec 2011 at 6:13

GoogleCodeExporter commented Apr 22, 2015

Hello Irie san,

We are not able to use external codes due to our company policy, even though it 
is from a contributor.  We use the internal code repository as our primary 
repository and we cannot check in any external code into the repository.  I 
admit this is inconvenient and confusing.  I have been figuring out a better 
way, but it would take a longer time to solve it.

Thank you for your patience,


Original comment by koma...@google.com on 2 Dec 2011 at 6:13

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Apr 22, 2015

Umm... I got it.

I hope that Google decides to change the company policy so that a small patch 
of at most about ten lines can be applied.

Thanks for the explanation.

Original comment by irieshin...@gmail.com on 2 Dec 2011 at 7:10

GoogleCodeExporter commented Apr 22, 2015

Umm... I got it.

I hope that Google decides to change the company policy so that a small patch 
of at most about ten lines can be applied.

Thanks for the explanation.

Original comment by irieshin...@gmail.com on 2 Dec 2011 at 7:10

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Apr 22, 2015

Original comment by n...@google.com on 21 Dec 2011 at 10:35

  • Changed state: Fixed

GoogleCodeExporter commented Apr 22, 2015

Original comment by n...@google.com on 21 Dec 2011 at 10:35

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment