New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_libprotobuf=1 does not work in Mozc 1.10.1390.102 #189

Closed
GoogleCodeExporter opened this Issue Apr 22, 2015 · 10 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 22, 2015

Building mozc-1.10.1390.102 fails with GYP_DEFINES='use_libprotobuf=1' like:
INFO: Running: make -j1 MAKE_JOBS=1 BUILDTYPE=Release builddir_name=out_linux 
V=1 ibus_mozc mozc_server mozc_tool mozc_renderer
  LD_LIBRARY_PATH=/home/tagoh/rpmbuild/BUILD/mozc-1.10.1390.102/out_linux/Release/lib.host:/home/tagoh/rpmbuild/BUILD/mozc-1.10.1390.102/out_linux/Release/lib.target:$LD_LIBRARY_PATH; export LD
_LIBRARY_PATH; cd config; mkdir -p 
/home/tagoh/rpmbuild/BUILD/mozc-1.10.1390.102/out_linux/Release/obj/gen/proto_ou
t/config; python ../build_tools/protoc_wrapper.py "--project_root=.." "--proto
c_path=../mozc_build_tools/linux/protoc" 
"--proto=/home/tagoh/rpmbuild/BUILD/mozc-1.10.1390.102/config/config.proto" 
"--cpp_out=/home/tagoh/rpmbuild/BUILD/mozc-1.10.1390.102/out_linux/Release/o
bj/gen/proto_out"
Traceback (most recent call last):
  File "../build_tools/protoc_wrapper.py", line 83, in <module>
    main()
  File "../build_tools/protoc_wrapper.py", line 80, in main
    sys.exit(subprocess.call(commands))
  File "/usr/lib64/python2.7/subprocess.py", line 493, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib64/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1249, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
make: *** [out_linux/Release/obj/gen/proto_out/config/config.pb.h] Error 1
Traceback (most recent call last):
  File "build_mozc.py", line 1463, in <module>
    main()
  File "build_mozc.py", line 1451, in main
    BuildMain(cmd_opts, cmd_args, original_directory_name)   
  File "build_mozc.py", line 1076, in BuildMain
    BuildOnLinux(options, targets, original_directory_name)  
  File "build_mozc.py", line 1029, in BuildOnLinux
    RunOrDie([make_command] + build_args + target_names)
  File "/home/tagoh/rpmbuild/BUILD/mozc-1.10.1390.102/build_tools/util.py", line 97, in RunOrDie
    '==========']))
build_tools.util.RunOrDieError:
==========
 ERROR: make -j1 MAKE_JOBS=1 BUILDTYPE=Release builddir_name=out_linux V=1 ibus_mozc mozc_server mozc_tool mozc_renderer
==========

No luck with protobuf 2.4.1 nor 2.5.0

What steps will reproduce the problem?
1.GYP_DEFINES='use_libprotobuf=1' python build_mozc.py gyp
2.python build_mozc.py build_tools -c Release
3.python build_mozc.py build -c Release unix/ibus/ibus.gyp:ibus_mozc 
server/server.gyp:mozc_server gui/gui.gyp:mozc_tool 
renderer/renderer.gyp:mozc_renderer

What is the expected output?
No errors

What do you see instead?
See above

What version of the product are you using? On what operating system?
mozc-1.10.1390.102
protobuf-2.4.1 or 2.5.0


Please provide any additional information below.

Original issue reported on code.google.com by ak...@tagoh.org on 16 Apr 2013 at 2:51

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Thank you for reporting this issue and sorry for bothering you.

I believe replacing "linux" with "Linux" in the following line solves this 
issue.
https://code.google.com/p/mozc/source/browse/trunk/src/protobuf/genproto.gypi?r=
131#36

Attached a patch.
Could you try it?

Original comment by yukawa@google.com on 16 Apr 2013 at 4:03

  • Changed state: Started
  • Added labels: OpSys-Linux

Attachments:

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Original comment by yukawa@google.com on 16 Apr 2013 at 4:19

  • Changed title: use_libprotobuf does=1 does not work in Mozc 1.10.1390.102
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Original comment by yukawa@google.com on 16 Apr 2013 at 4:28

  • Changed title: use_libprotobuf=1 does not work in Mozc 1.10.1390.102
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Unfortunately still not working. full build logs are available here:
  http://kojipkgs.fedoraproject.org//work/tasks/7427/5257427/build.log

Original comment by ak...@tagoh.org on 16 Apr 2013 at 9:25

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

We have to change
-            'protoc_command%': 'protoc<(EXECUTABLE_SUFFIX)',
+            'protoc_command%': '/usr/bin/protoc<(EXECUTABLE_SUFFIX)',
or fix protoc_wrapper.py which always expects relative path.

Original comment by f.takeya...@gmail.com on 16 Apr 2013 at 10:57

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Oops, sorry again and thank you for trying it.

Attached a new patch. I confirmed that we can build Mozc with this patch (and 
the patch attached in Issue 186) on today's rawhide.

Original comment by yukawa@google.com on 16 Apr 2013 at 11:58

  • Changed state: Fixed

Attachments:

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Updated the patch to fix another typo when use_libprotobuf=0 yey!

And change the status back to "Started" just for searchability.
I'll close this issue when the next push is released with this patch.

Original comment by yukawa@google.com on 16 Apr 2013 at 12:16

  • Changed state: Started

Attachments:

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

FYI, as far as I've tested, you can still build Mozc with protobuf-2.4.1 as 
long as this patch is applied.

Original comment by yukawa@google.com on 17 Apr 2013 at 2:12

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Thanks for updating. it works for me too!

Original comment by ak...@tagoh.org on 17 Apr 2013 at 9:23

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

FYI, r163 contains the patch.

Original comment by yukawa@google.com on 17 Jul 2013 at 3:19

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment