New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion candidates are not shown completely when converting word 'あきな' (single word conversion) #220

Closed
GoogleCodeExporter opened this Issue Apr 22, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 22, 2015

What steps will reproduce the problem?
1. Type 'あきな'
2. Press space-key twice to show conversion candidates

What is the expected output?
All words defined as 'あきな' in the dictionary (about 24) should be shown 
in the candidates list.

What do you see instead?
The words defined in the dictionary seems to be shown only about 8.

What version of the product are you using? On what operating system?
Mozc-1.15.1785.102

Please provide any additional information below.
If type as segment (あきなと、) or adding honorific (あきなさん), all 
defined words seems to be shown.

Original issue reported on code.google.com by cabezon....@gmail.com on 26 May 2014 at 10:19

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 22, 2015

Thank you for letting us know this issue.  We found an unexpected code path 
that could explain the behavior you reported regarding 'あきな'.  r207 
should contain the fix for this particular case.

> What is the expected output?
> All words defined as 'あきな' in the dictionary (about 24) should be shown 
in the candidates list.

Note that it is still not guaranteed that all the words defined in the 
dictionary text files are always included in the candidates list.  There are 
several filtering rules that may drop words defined in the source text 
dictionary.  Actually the issue you reported was caused by an integer overflow 
in mozc::converter::CandidateFilter, which behaves as an arbiter at runtime not 
only to improve the (computational and conversion) performance but also to 
implement suppression word (抑制単語) feature.

r207 fixed the integer overflow but the mozc::converter::CandidateFilter still 
exists there.  It may prevent some words from being shown in the candidates 
list.

Having said that, your report was a great help for us to find this unexpected 
behavior. Thank you again for your report.

Original comment by yukawa@google.com on 21 Jun 2014 at 9:55

  • Changed state: Fixed
  • Added labels: OpSys-All
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment